Skip to content

Commit 2ae89af

Browse files
committed
address comments
1 parent d8ab791 commit 2ae89af

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

example/cacheHierarchy/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,20 +46,20 @@ if(NOT LIBCACHESIM_LIBRARY OR NOT LIBCACHESIM_INCLUDE_DIR)
4646
message(FATAL_ERROR "libCacheSim not found! Please install libCacheSim first.")
4747
endif()
4848

49-
add_executable(cacheH main.cpp myconfig.cpp simulator.cpp utils.cpp)
49+
add_executable(cacheHierarchy main.cpp myconfig.cpp simulator.cpp utils.cpp)
5050

51-
target_include_directories(cacheH PRIVATE
51+
target_include_directories(cacheHierarchy PRIVATE
5252
${ZSTD_INCLUDE_DIR}
5353
${LIBCACHESIM_INCLUDE_DIR}
5454
)
5555

5656
# Add GLib compile and link flags
57-
target_compile_options(cacheH PRIVATE ${GLIB_CFLAGS_OTHER})
58-
target_include_directories(cacheH PRIVATE ${GLIB_INCLUDE_DIRS})
59-
target_link_directories(cacheH PRIVATE ${GLIB_LIBRARY_DIRS})
57+
target_compile_options(cacheHierarchy PRIVATE ${GLIB_CFLAGS_OTHER})
58+
target_include_directories(cacheHierarchy PRIVATE ${GLIB_INCLUDE_DIRS})
59+
target_link_directories(cacheHierarchy PRIVATE ${GLIB_LIBRARY_DIRS})
6060

6161

62-
target_link_libraries(cacheH
62+
target_link_libraries(cacheHierarchy
6363
${LIBCACHESIM_LIBRARY}
6464
m
6565
${GLIB_LIBRARIES}

example/cacheHierarchy/simulator.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ double Simulator::gen_miss_trace(string algo, uint64_t cache_size,
2121
.obj_size_field = 3,
2222
.next_access_vtime_field = 4};
2323
// see the cacheSimulator example for using csv trace
24-
reader_init_params.binary_fmt_str = (char *)"<IQIQ";
24+
reader_init_params.binary_fmt_str = strdup("<IQIQ");
2525
reader_t *reader =
2626
open_trace(trace_path.c_str(), BIN_TRACE, &reader_init_params);
2727
common_cache_params_t cc_params = {.cache_size = cache_size};
@@ -54,7 +54,7 @@ void Simulator::output_mrc(string &algo, vector<uint64_t> cache_sizes,
5454
char alg[] = "LRU";
5555
reader_init_param_t reader_init_params = {
5656
.time_field = 1, .obj_id_field = 2, .obj_size_field = 3};
57-
reader_init_params.binary_fmt_str = (char *)"<III";
57+
reader_init_params.binary_fmt_str = strdup("<III");
5858
reader_t *reader =
5959
open_trace(trace_path.c_str(), BIN_TRACE, &reader_init_params);
6060

0 commit comments

Comments
 (0)