[Fix] enhance param parse for LRB and 3L (#248)

Author: haochengxia

libCacheSim/cache/eviction/3LCache/ThreeLCache_Interface.cpp

@@ -323,7 +323,7 @@ static const char *ThreeLCache_current_params(cache_t *cache,
   static __thread char params_str[128];
   int n = snprintf(params_str, 128, "objective=%s", params->objective);
 
-  snprintf(cache->cache_name + n, 128 - n, "\n");
+  snprintf(params_str + n, 128 - n, "\n");
 
   return params_str;
 }
@@ -340,6 +340,13 @@ static void ThreeLCache_parse_params(cache_t *cache,
     char *key = strsep((char **)&params_str, "=");
     char *value = strsep((char **)&params_str, ",");
 
+    if (key == NULL || value == NULL) {
+      ERROR("invalid parameter format in %s: %s\n", cache->cache_name,
+            cache_specific_params);
+      free(original_params_str);
+      exit(1);
+    }
+
     // skip the white space
     while (params_str != NULL && *params_str == ' ') {
       params_str++;

libCacheSim/cache/eviction/LRB/LRB_Interface.cpp

@@ -95,6 +95,8 @@ cache_t *LRB_init(const common_cache_params_t ccache_params,
   LRB_params_t *params = my_malloc(LRB_params_t);
   cache->eviction_params = params;
 
+  params->objective = nullptr;
+
   LRB_parse_params(cache, DEFAULT_PARAMS);
   if (cache_specific_params != NULL) {
     LRB_parse_params(cache, cache_specific_params);
@@ -311,7 +313,7 @@ static const char *LRB_current_params(cache_t *cache, LRB_params_t *params) {
   static __thread char params_str[128];
   int n = snprintf(params_str, 128, "objective=%s", params->objective);
 
-  snprintf(cache->cache_name + n, 128 - n, "\n");
+  snprintf(params_str + n, 128 - n, "\n");
 
   return params_str;
 }
@@ -328,6 +330,13 @@ static void LRB_parse_params(cache_t *cache,
     char *key = strsep((char **)&params_str, "=");
     char *value = strsep((char **)&params_str, ",");
 
+    if (key == NULL || value == NULL) {
+      ERROR("invalid parameter format in %s: %s\n", cache->cache_name,
+            cache_specific_params);
+      free(original_params_str);
+      exit(1);
+    }
+
     // skip the white space
     while (params_str != NULL && *params_str == ' ') {
       params_str++;