Apply the suggestion from copilot

Author: haochengxia

libCacheSim-python/src/pylibcachesim.cpp

@@ -164,8 +164,6 @@ struct ReaderDeleter {
   }
 };
 
-namespace py = pybind11;
-
 PYBIND11_MODULE(_libcachesim, m) {  // NOLINT(readability-named-parameter)
   m.doc() = R"pbdoc(
         libCacheSim Python bindings
@@ -617,7 +615,8 @@ PYBIND11_MODULE(_libcachesim, m) {  // NOLINT(readability-named-parameter)
   /**
    * @brief Create a TinyLFU cache instance.
    */
-  // mark evivtion parsing need change
+  // TODO: Review and update the eviction parsing logic in TinyLFU_init if
+  // necessary.
   m.def(
       "TinyLFU_init",
       [](uint64_t cache_size, std::string main_cache, double window_size) {

libCacheSim-python/tests/utils.py

@@ -9,9 +9,8 @@ def get_reference_data(eviction_algo, cache_size_ratio):
     )
     with open(data_file, "r") as f:  # noqa: PTH123
         lines = f.readlines()
+        key = "3LCache" if eviction_algo == "ThreeLCache" else eviction_algo
         for line in lines:
-            if eviction_algo == "ThreeLCache":
-                eviction_algo = "3LCache"
-            if line.startswith(f"{eviction_algo},{cache_size_ratio}"):
+            if line.startswith(f"{key},{cache_size_ratio}"):
                 return float(line.split(",")[-1])
     return None

scripts/install_python.sh

@@ -1,4 +1,5 @@
 #!/bin/bash
+set -euo pipefail
 
 # Build the main libCacheSim C++ library first
 echo "Building main libCacheSim library..."

scripts/sync_python_version.py

@@ -51,7 +51,11 @@ def update_pyproject_toml(version):
         pyproject_data = f.read()
 
     # Update the version line in pyproject.toml, make it can match any version in version.txt, like "0.3.1" or "dev"
-    current_version = re.search(r"version = \"(dev|[0-9]+\.[0-9]+\.[0-9]+)\"", pyproject_data).group(1)
+    match = re.search(r"version = \"(dev|[0-9]+\.[0-9]+\.[0-9]+)\"", pyproject_data)
+    if not match:
+        print("Error: Could not find a valid version line in pyproject.toml", file=sys.stderr)
+        return False
+    current_version = match.group(1)
     if current_version == version:
         print(f"Python binding version already up to date: {version}")
         return False
@@ -77,9 +81,9 @@ def main():
         updated = update_pyproject_toml(main_version)
 
         if updated:
-            print("✓ Python binding version synchronized successfully")
+            print("Python binding version synchronized successfully")
         else:
-            print("✓ No changes needed")
+            print("No changes needed")
     except Exception as e:
         print(f"Error: {e}", file=sys.stderr)
         sys.exit(1)