Remove create_cache

Author: haochengxia

libCacheSim-python/libcachesim/__init__.py

@@ -6,7 +6,6 @@
     Request,
     __doc__,
     __version__,
-    create_cache,
     open_trace,
     process_trace,
     process_trace_python_hook,
@@ -44,7 +43,6 @@
     "PythonHookCachePolicy",
     "__doc__",
     "__version__",
-    "create_cache",
     "open_trace",
     "process_trace",
     "process_trace_python_hook",

libCacheSim-python/libcachesim/__init__.pyi

@@ -7,7 +7,6 @@ libCacheSim Python bindings
 .. autosummary::
     :toctree: _generate
 
-    create_cache
     open_trace
     ARC_init
     Clock_init
@@ -28,14 +27,6 @@ libCacheSim Python bindings
 
 from .const import TraceType
 
-def create_cache(
-    eviction_algo: str,
-    cache_size: int,
-    eviction_params: str,
-    consider_obj_metadata: bool
-) -> Cache: ...
-
-
 def open_trace(
     trace_path: str,
     type: TraceType,

libCacheSim-python/src/pylibcachesim.cpp

@@ -364,29 +364,6 @@ PYBIND11_MODULE(_libcachesim, m) {  // NOLINT(readability-named-parameter)
                 Reader: A new reader instance for the trace.
         )pbdoc");
 
-  /**
-   * @brief Generic function to create a cache instance.
-   */
-  m.def(
-      "create_cache",
-      [](const std::string& eviction_algo, const uint64_t cache_size,
-         const std::string& eviction_params,
-         bool consider_obj_metadata) { return nullptr; },
-      py::arg("eviction_algo"), py::arg("cache_size"),
-      py::arg("eviction_params"), py::arg("consider_obj_metadata"),
-      R"pbdoc(
-            Create a cache instance.
-
-            Args:
-                eviction_algo (str): Eviction algorithm to use (e.g., "LRU", "FIFO", "Random").
-                cache_size (int): Size of the cache in bytes.
-                eviction_params (str): Additional parameters for the eviction algorithm.
-                consider_obj_metadata (bool): Whether to consider object metadata in eviction decisions.
-
-            Returns:
-                Cache: A new cache instance.
-        )pbdoc");
-
   /* TODO(haocheng): should we support all parameters in the
    * common_cache_params_t? (hash_power, etc.) */
 

libCacheSim-python/tests/test_eviction.py

@@ -12,20 +12,19 @@
     Sieve,
     TinyLFU,
     TwoQ,
-    create_cache,
 )
 from tests.utils import get_reference_data
 
 
 @pytest.mark.parametrize("eviction_algo", [
     FIFO,
     ARC,
-    # Clock,
-    # LRU,
-    # S3FIFO,
-    # Sieve,
-    # TinyLFU,
-    # TwoQ,
+    Clock,
+    LRU,
+    S3FIFO,
+    Sieve,
+    TinyLFU,
+    TwoQ,
 ])
 @pytest.mark.parametrize("cache_size_ratio", [0.01])
 def test_eviction_algo(eviction_algo, cache_size_ratio, mock_reader):
@@ -35,7 +34,7 @@ def test_eviction_algo(eviction_algo, cache_size_ratio, mock_reader):
         cache = eviction_algo(cache_size=int(mock_reader.get_wss()*cache_size_ratio))
         req_count = 0
         miss_count = 0
-        
+
         # Limit the number of requests to avoid long test times
         # max_requests = 1000
         for i, req in enumerate(mock_reader):
@@ -45,50 +44,18 @@ def test_eviction_algo(eviction_algo, cache_size_ratio, mock_reader):
             if not hit:
                 miss_count += 1
             req_count += 1
-        
+
         if req_count == 0:
             pytest.skip("No requests processed")
-            
+
         miss_ratio = miss_count / req_count
         reference_miss_ratio = get_reference_data(eviction_algo.__name__, cache_size_ratio)
         if reference_miss_ratio is None:
             pytest.skip(f"No reference data for {eviction_algo.__name__} with cache size ratio {cache_size_ratio}")
         assert abs(miss_ratio - reference_miss_ratio) < 0.01, f"Miss ratio {miss_ratio} is not close to reference {reference_miss_ratio}"
-        
+
     except Exception as e:
         print(f"Error in test_eviction_algo: {e}")
         raise
     finally:
         pass
-
-
-# @pytest.mark.parametrize("eviction_algo", [
-#     "FIFO",
-#     "ARC",
-#     "Clock",
-#     "LRU",
-#     "S3FIFO",
-#     "Sieve",
-#     "TinyLFU",
-#     "TwoQ",
-# ])
-# @pytest.mark.parametrize("cache_size_ratio", [0.01, 0.1])
-# def test_eviction_algo_generic(eviction_algo, cache_size_ratio, mock_reader):
-#     cache = create_cache(eviction_algo=eviction_algo,
-#                 cache_size=int(mock_reader.get_wss()*cache_size_ratio),
-#                 eviction_params="",
-#                 consider_obj_metadata=False)
-#     req_count = 0
-#     miss_count = 0
-#     for req in mock_reader:
-#         hit = cache.get(req)
-#         if not hit:
-#             miss_count += 1
-#         req_count += 1
-
-#     miss_ratio = miss_count / req_count
-#     print("Check eviction algo: ", eviction_algo, "with cache size ratio: ", cache_size_ratio)
-#     reference_miss_ratio = get_reference_data(eviction_algo, cache_size_ratio)
-#     if reference_miss_ratio is None:
-#         pytest.skip(f"No reference data for {eviction_algo} with cache size ratio {cache_size_ratio}")
-#     assert abs(miss_ratio - reference_miss_ratio) < 0.01, f"Miss ratio {miss_ratio} is not close to reference {reference_miss_ratio}"