Add check for strlen

Author: haochengxia

libCacheSim-python/src/cache_init.hpp

@@ -69,13 +69,18 @@ static inline cache_t *create_sim_cache(const char *eviction_algo,
     } else {
       const char *window_size = strstr(eviction_params, "window-size=");
       if (window_size == NULL) {
-        char *new_params = (char *)malloc(strlen(eviction_params) + 20);
-        if (strlen(eviction_params) > 0) {
-          sprintf(new_params, "%s,window-size=0.01", eviction_params);
+        char dest[30];
+        strncpy(dest, eviction_params, 30);
+        dest[29] = '\0';
+        size_t param_len = strlen(dest);
+        char *new_params = (char *)malloc(param_len + 20);
+        if (param_len > 0) {
+          snprintf(new_params, param_len + 20, "%s,window-size=0.01", eviction_params);
         } else {  // if eviction_params is "", no comma is needed
-          sprintf(new_params, "window-size=0.01");
+          snprintf(new_params, 20, "window-size=0.01");
         }
         cache = WTinyLFU_init(cc_params, new_params);
+        free(new_params);
       } else {
         cache = WTinyLFU_init(cc_params, eviction_params);
       }