Remove test for lrb and 3l

Author: haochengxia

.github/workflows/python.yml

@@ -16,13 +16,6 @@ jobs:
       - name: Prepare
         run: bash scripts/install_dependency.sh
 
-      - name: Install XGBoost and LightGBM
-        run: |
-          pip install xgboost lightgbm
-          # Set environment variables to help CMake find the libraries
-          echo "XGBOOST_ROOT=$(python -c 'import xgboost; print(xgboost.__file__)')" >> $GITHUB_ENV
-          echo "LIGHTGBM_ROOT=$(python -c 'import lightgbm; print(lightgbm.__file__)')" >> $GITHUB_ENV
-      
       - name: Install Python dependencies
         run: |
           pip install --upgrade pip

libCacheSim-python/CMakeLists.txt

@@ -113,7 +113,7 @@ else()
 endif()
 
 # Only include sources if dependencies are available
-if(ENABLE_XGBOOST)
+if(ENABLE_LIGHTGBM)
     file(GLOB_RECURSE LRB_SOURCES
         "${CMAKE_CURRENT_SOURCE_DIR}/../libCacheSim/cache/eviction/LRB/*.cpp"
     )
@@ -123,6 +123,10 @@ if(ENABLE_XGBOOST)
 else()
     set(LRB_SOURCES "")
     set(3L_CACHE_SOURCES "")
+
+    # disable the features
+    add_compile_definitions(ENABLE_3L_CACHE=0)
+    add_compile_definitions(ENABLE_LRB=0)
 endif()
 
 file(GLOB_RECURSE CACHE_CPP_SOURCES

libCacheSim-python/src/pylibcachesim.cpp

@@ -277,6 +277,7 @@ PYBIND11_MODULE(_libcachesim, m) {
                 Cache: A new FIFO cache instance.
       )pbdoc");
 
+#ifdef ENABLE_LRB
   /**
    * @brief Create a LRB cache instance.
    */
@@ -298,6 +299,15 @@ PYBIND11_MODULE(_libcachesim, m) {
             Returns:
                 Cache: A new LRB cache instance.
       )pbdoc");
+#else
+  // TODO(haocheng): add a dummy function to avoid the error when LRB is not enabled
+  m.def(
+      "LRB_init",
+      [](uint64_t cache_size, std::string objective) {
+        throw std::runtime_error("LRB is not enabled");
+      },
+      py::arg("cache_size"), py::arg("objective") = "byte-miss-ratio");
+#endif
 
   /**
    * @brief Create a LRU cache instance.
@@ -372,6 +382,7 @@ PYBIND11_MODULE(_libcachesim, m) {
                 Cache: A new Sieve cache instance.
       )pbdoc");
 
+#ifdef ENABLE_3L_CACHE
   /**
    * @brief Create a ThreeL cache instance.
    */
@@ -394,6 +405,15 @@ PYBIND11_MODULE(_libcachesim, m) {
             Returns:
                 Cache: A new ThreeL cache instance.
       )pbdoc");
+#else
+  // TODO(haocheng): add a dummy function to avoid the error when ThreeLCache is not enabled
+  m.def(
+      "ThreeLCache_init",
+      [](uint64_t cache_size, std::string objective) {
+        throw std::runtime_error("ThreeLCache is not enabled");
+      },
+      py::arg("cache_size"), py::arg("objective") = "byte-miss-ratio");
+#endif
 
   /**
    * @brief Create a TinyLFU cache instance.

libCacheSim-python/tests/test_eviction.py

@@ -14,11 +14,11 @@
     FIFO,
     ARC,
     Clock,
-    LRB,
+    # LRB,
     LRU,
     S3FIFO,
     Sieve,
-    ThreeLCache,
+    # ThreeLCache,
     TinyLFU,
     TwoQ,
 ])
@@ -45,11 +45,11 @@ def test_eviction_algo(eviction_algo, cache_size_ratio, mock_reader):
     "FIFO",
     "ARC",
     "Clock",
-    "LRB",
+    # "LRB",
     "LRU",
     "S3FIFO",
     "Sieve",
-    "3LCache",
+    # "3LCache",
     "TinyLFU",
     "TwoQ",
 ])