Skip to content

Commit fea7e86

Browse files
committed
Exclude pybind in clang-tidy
1 parent 49e2c91 commit fea7e86

File tree

6 files changed

+275
-83
lines changed

6 files changed

+275
-83
lines changed

.github/workflows/code-quality.yml

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,18 @@ jobs:
3232
**/*.cc
3333
**/*.hpp
3434
35+
- name: Get changed C/C++ files excluding python binding
36+
id: changed-files-without-pybind
37+
uses: tj-actions/changed-files@v46.0.5
38+
with:
39+
files: |
40+
**/*.c
41+
**/*.h
42+
**/*.cpp
43+
**/*.cc
44+
**/*.hpp
45+
!libCacheSim-python/**
46+
3547
- name: Create log directory
3648
run: mkdir -p logs
3749

@@ -67,12 +79,12 @@ jobs:
6779
-DCMAKE_EXPORT_COMPILE_COMMANDS=ON
6880
6981
- name: Clang-tidy check
70-
if: steps.changed-files.outputs.any_changed == 'true'
82+
if: steps.changed-files-without-pybind.outputs.any_changed == 'true'
7183
run: |
7284
echo "Running clang-tidy checks..."
7385
FILES_WITH_ISSUES=0
7486
75-
for file in ${{ steps.changed-files.outputs.all_changed_files }}; do
87+
for file in ${{ steps.changed-files-without-pybind.outputs.all_changed_files }}; do
7688
echo "Checking $file with clang-tidy"
7789
LOG_FILE="logs/tidy_$(basename "$file").log"
7890

libCacheSim-python/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -187,6 +187,7 @@ target_link_libraries(_libcachesim PRIVATE
187187
cachesim_c
188188
cachesim_cpp
189189
pybind11::headers
190+
pybind11::module
190191
${GLIB2_LIBRARIES}
191192
${XGBOOST_LIBRARIES}
192193
${LIGHTGBM_LIBRARIES}

0 commit comments

Comments
 (0)