Skip to content

fix github action triggering a new release upon each commit #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1a1a11a merged 1 commit into from
Jun 18, 2025
Merged

fix github action triggering a new release upon each commit #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/npm-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ env:

jobs:
create-release:
if: github.event_name == 'release'
runs-on: ubuntu-latest
outputs:
release_created: ${{ steps.release.outputs.release_created }}
Expand Down Expand Up @@ -70,6 +71,7 @@ jobs:
prerelease: false

build-and-publish:
if: github.event_name == 'release'
needs: create-release
runs-on: ubuntu-latest

Expand Down Expand Up @@ -130,6 +132,7 @@ jobs:
node -e "console.log('Testing binary load...'); try { require('./index.js'); console.log('Binary loaded successfully!'); } catch(e) { console.error('Failed to load binary:', e); process.exit(1); }"

publish-npm:
if: github.event_name == 'release'
needs: build-and-publish
runs-on: ubuntu-latest

Expand Down Expand Up @@ -161,6 +164,7 @@ jobs:
cp _build/liblibCacheSim.a libCacheSim-node/vendor/
cp -r libCacheSim/include/* libCacheSim-node/vendor/include/


- name: Publish to NPM
working-directory: libCacheSim-node
run: npm publish --access public
Expand Down