1a1a11a/cleanup CMakeList

[1a1a11a]

No description provided.

[haochengxia]

Do we want to remove dev dep like clang-tidy from setup_ubuntu and only preserve it in install_dev? Now both of them have it.

[1a1a11a]

will update

[1a1a11a]

This one depends on #201.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[haochengxia]

Some thoughts:

1. Is it necessary to reduce the usage of global set?
   e.g.,

   set(LIBS ${LIBS} ${GLib_LIBRARY})
   set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra ...")
   
   ->
   
   target_compile_options(${PROJECT_NAME} PRIVATE -Wall -Wextra -Werror ...)
   target_link_libraries(${PROJECT_NAME} PRIVATE ${GLib_LIBRARIES})
   

2. Should we use set(... PARENT_SCOPE) in subdir's CMakeLists.txt to expose the file to compile in subdir instead of organize the code via manually gathering all source code in the main CMakeLists.txt?
   e.g.,

   # libCacheSim/dataStructure/CMakeLists.txt
   
   set(DATASTRUCTURE_SOURCES
       pqueue.c
       splay.c
       bloom.c
       minimalIncrementCBF.c
       histogram.c
       splay_tuple.c
      ...
       PARENT_SCOPE
   )
   
   # CMakeLists.txt
   add_library(${PROJECT_NAME} 
       ${DATASTRUCTURE_SOURCES}
   ...)
   
   

3. Do we want to export libCacheSimConfig.cmake?

[1a1a11a]

Some thoughts:

1. Is it necessary to reduce the usage of global set?
   e.g.,

   set(LIBS ${LIBS} ${GLib_LIBRARY})
   set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -Wall -Wextra ...")
   
   ->
   
   target_compile_options(${PROJECT_NAME} PRIVATE -Wall -Wextra -Werror ...)
   target_link_libraries(${PROJECT_NAME} PRIVATE ${GLib_LIBRARIES})
   

2. Should we use set(... PARENT_SCOPE) in subdir's CMakeLists.txt to expose the file to compile in subdir instead of organize the code via manually gathering all source code in the main CMakeLists.txt?
   e.g.,

   # libCacheSim/dataStructure/CMakeLists.txt
   
   set(DATASTRUCTURE_SOURCES
       pqueue.c
       splay.c
       bloom.c
       minimalIncrementCBF.c
       histogram.c
       splay_tuple.c
      ...
       PARENT_SCOPE
   )
   
   # CMakeLists.txt
   add_library(${PROJECT_NAME} 
       ${DATASTRUCTURE_SOURCES}
   ...)
   

3. Do we want to export libCacheSimConfig.cmake?

1 . good point, updated. I used a global variable to allow use change, but I set the property on each lib, so we can change independently.
2. I agree, updated and also cleaned up more, which causes the changes in this PR to be huge
3. added libCacheSimTargets.cmake to cmake

because I added a global include, so I will also update the various header include not to use relative path.
But I will do it in the next PR to avoid making too many changes in this PR...

[1a1a11a]

I temporarily removed mrcProfiler from the test because the plugin system needs more work and will be addressed separately.

[1a1a11a]

@haochengxia ready to review

[haochengxia]

LGTM!

P.S.: I noticed that in some places, such as admission, we used include_directories to include header files, so we no longer need relative paths. Should we apply this to the project scope? If yes, I'd like to create one PR using target_include_directories/include_directories.

[1a1a11a]

I think with the current structure, we include the libCacheSim header path include/libCacheSim for every target, and we add target_include_directory for others if needed.
The CMakeLists in admission is not needed any more (and just removed in the new commit), it is merged into a higher-level CMakeLists, which reduces the number of lib and avoids circular dependency.

[Copilot]

Pull Request Overview

This PR cleans up and refactors multiple CMakeLists and associated build scripts while updating target names, include paths, and dependency handling across the project.

• Refactored test executable creation and linking in CMakeLists.txt for better maintainability.
• Removed outdated files (e.g. .travis.yml and lint.sh) and improved consistency in shell scripts and library targets.
• Updated source file include paths and target properties for various modules (e.g. traceReader, profiler, eviction algorithms).

Reviewed Changes

Copilot reviewed 26 out of 64 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/CMakeLists.txt	Refactored test executable function and updated target linkage.
scripts/lint.sh	Removed; likely replaced by new linting mechanisms.
scripts/install_dev_dependency.sh	New script for development dependency installation with logging improvements.
scripts/install_dependency.sh	Improved syntax with modern bash practices and removed the verbose option.
libCacheSim/utils/CMakeLists.txt	Updated target creation for the utils library with modern flags and include paths.
libCacheSim/traceReader/CMakeLists.txt	Improved naming for source variables and updated linking for the traceReader library.
libCacheSim/traceAnalyzer/*	Updated include paths and formatting consistency in traceAnalyzer sources.
libCacheSim/profiler/CMakeLists.txt	Refactored profiler library target with updated compiler flags and linking.
libCacheSim/mrcProfiler/CMakeLists.txt	Standardized C++ target properties and dependency linking.
libCacheSim/include/libCacheSim/evictionAlgo.h	Formatted function declarations for consistency and readability.
libCacheSim/dataStructure/CMakeLists.txt	Added new sources and improved target configuration for the data structure library.
libCacheSim/cache/prefetch/CMakeLists.txt	Removed legacy prefetch target as part of cleanup.
libCacheSim/cache/eviction/priv/myMQv1.c	Removed unfinished eviction algorithm implementation.
libCacheSim/cache/eviction/other/S3LRU.c	Corrected include paths for consistency.
libCacheSim/cache/eviction/RandomLRU.c	Added allocation and cleanup for eviction candidates and improved formatting.
libCacheSim/cache/eviction/CMakeLists.txt	Removed unused eviction algorithm C source file list.
libCacheSim/cache/admission/*	Updated include paths in admission algorithms and removed obsolete CMakeLists.
libCacheSim/cache/CMakeLists.txt	Reorganized modular libraries and unified dependency management; added install rules.
CMakeLists.txt	Consolidated compiler flags, dependency resolution, and installation targets; removed outdated options.
.travis.yml	Removed CI configuration file; likely migrated to a different CI system.

Comments suppressed due to low confidence (1)

[Copilot]

Consider removing obsolete commented-out code in the sorting comparator section to improve code clarity and maintainability.