fix relative import and format; disable clang-tidy for now#210
Merged
fix relative import and format; disable clang-tidy for now#210
Conversation
1a1a11a
requested review from
Copilot and
haochengxia
and removed request for
haochengxia
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on updating include paths from deeply relative paths to a standardized project-based path, reformatting code blocks and macros, and disabling clang‑tidy temporarily to bypass header-not‑found issues with mixed C/C++ code. The key changes include:
- Adjusting all include directives to use paths like "libCacheSim/xxx" instead of "../../../include/libCacheSim/xxx".
- Reformatting functions and macros for improved readability and consistency.
- Minor updates in inline functions and header formatting while disabling clang‑tidy.
Reviewed Changes
Copilot reviewed 198 out of 304 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| libCacheSim/traceAnalyzer/utils/include/utils.h | Update of relative include for logging to a project path. |
| libCacheSim/traceAnalyzer/ttl.h | Changed header includes to use project-relative path. |
| libCacheSim/dataStructure/ut/utstring.h | Reformatted macro definitions for clarity and consistency. |
| ... (other files) | Similar include path updates and formatting adjustments. |
| libCacheSim/CMakeLists.txt | Added target‐include directories supporting updated layout. |
Comments suppressed due to low confidence (3)
libCacheSim/traceAnalyzer/utils/include/utils.h:9
- The include path has been updated from a relative path to a project-based path. Please ensure that the build configuration (e.g., CMake include directories) is updated accordingly to avoid missing header issues.
#include "libCacheSim/logging.h"
libCacheSim/traceAnalyzer/ttl.h:12
- The header path was changed to a project-relative path. Verify that all dependent modules and build scripts (like CMakeLists.txt) are adjusted to reflect this new structure.
#include "libCacheSim/request.h"
libCacheSim/dataStructure/ut/utstring.h:31
- [nitpick] The reformatting of macro definitions improves readability; please validate that these modifications do not alter macro behavior in edge cases.
#include <stdarg.h>
haochengxia
reviewed
Jun 21, 2025
Collaborator
haochengxia
left a comment
haochengxia
left a comment
There was a problem hiding this comment.
LGTM! A huge formatting PR. Only one possible replacement issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly formatting and minor updates
I have tried to fix clang-tidy issues; however, it keeps reporting that the C++ header is not found. Not sure why, I guess it might be triggered because we have both c and c++ code mixed. So I disabled clang-tidy for now.