Conversation
1a1a11a
requested review from
Copilot and
haochengxia
and removed request for
haochengxia
There was a problem hiding this comment.
Pull Request Overview
Adds Trunk CI configuration and supporting linter settings to the repo.
- Introduces
.trunk/trunk.yamlto configure Trunk CLI, plugins, runtimes, linters, and actions. - Adds individual linter configuration files under
.trunk/configs/for SVGO, Ruff, Yamllint, ShellCheck, MarkdownLint, isort, and Hadolint. - Updates
.trunk/.gitignoreto exclude Trunk-generated artifacts.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .trunk/trunk.yaml | Configure Trunk CLI version, plugins, runtimes, enabled/disabled checks |
| .trunk/configs/svgo.config.mjs | SVGO plugin overrides for default optimization rules |
| .trunk/configs/ruff.toml | Ruff rule selection and E501 ignore |
| .trunk/configs/.yamllint.yaml | Custom Yamllint rules for quoted strings, duplicates, and octals |
| .trunk/configs/.shellcheckrc | Enable all ShellCheck rules and disable SC2154 |
| .trunk/configs/.markdownlint.yaml | Extend Prettier-friendly MarkdownLint style |
| .trunk/configs/.isort.cfg | Use Black profile for isort |
| .trunk/configs/.hadolint.yaml | Ignore SC1090/SC1091 for Hadolint |
| .trunk/.gitignore | Ignore Trunk output, logs, plugins, and temporary files |
Comments suppressed due to low confidence (1)
.trunk/trunk.yaml:22
- Duplicate
taplo@0.9.3entry inlint.enabled. Remove the redundant line to avoid running the same linter twice.
- taplo@0.9.3
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
haochengxia
left a comment
haochengxia
left a comment
There was a problem hiding this comment.
Should we add .github/workflows/trunk-check.yaml in this PR?
| # This is the section where you manage your linters. (https://docs.trunk.io/check/configuration) | ||
| lint: | ||
| enabled: | ||
| - taplo@0.9.3 |
There was a problem hiding this comment.
We can add eslint@8.56.0 to enable the check for .js files from node binding.
It might be better to add it in a separate PR so that we do not force everyone to use it immediately, which gives us more time to tune the config if needed. I learned a lesson when I enabled clang-format and clang-tidy too quickly. Let's first test it out locally before adding it to CI/CD. We can also enable pre-commit and pre-push features over time. |
Yes, agree! We may require a corresponding update to setup-hook.sh, which seems currently broken. |
No description provided.