Skip to content

refactor: fix macos build and cleanup cmake#221

Merged
1a1a11a merged 7 commits intodevelopfrom
1a1a1a/macos_build
Jun 22, 2025
Merged

refactor: fix macos build and cleanup cmake#221
1a1a11a merged 7 commits intodevelopfrom
1a1a1a/macos_build

Conversation

@1a1a11a
Copy link
Copy Markdown
Owner

@1a1a11a 1a1a11a commented Jun 22, 2025

This PR fixes the build on macOS. During the fix, a few more cmake changes are introduced. Notably, we previously used export_dynamic linked flag, which is not available on MacOS, now we changed the symbols to default visibility.

@1a1a11a 1a1a11a requested a review from haochengxia as a code owner June 22, 2025 18:48
@trunk-io
Copy link
Copy Markdown

trunk-io Bot commented Jun 22, 2025

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@1a1a11a 1a1a11a requested a review from Copilot June 22, 2025 18:48

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cursor[bot]

This comment was marked as outdated.

@1a1a11a 1a1a11a force-pushed the 1a1a1a/macos_build branch from 65059b0 to 34a052a Compare June 22, 2025 19:02
cursor[bot]

This comment was marked as outdated.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1a1a11a 1a1a11a force-pushed the 1a1a1a/macos_build branch from 34a052a to 52b3c7d Compare June 22, 2025 19:09
@1a1a11a 1a1a11a requested a review from Copilot June 22, 2025 19:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the macOS build and cleans up various CMake configurations and code formatting issues. Key changes include conversion specifier updates for printing 64‐bit values, modifications to CMake linking and visibility settings, and renaming/reordering of several cache eviction function prototypes.

Reviewed Changes

Copilot reviewed 33 out of 97 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/test_dataStructure.c Updated printf format specifier for obj_id printing
test/CMakeLists.txt Changed linking dependency from common modules to profiler/core libraries
scripts/* Improved cross‐platform support for processor count and dependency installation
libCacheSim/utils/mystr.* Updated conversion function to use snprintf with explicit buffer length
libCacheSim/trace* Updated printf format specifiers and linking options
libCacheSim/profiler/, mrcProfiler/ Adjusted printf conversion specifiers to correctly cast 64‐bit values
libCacheSim/include/libCacheSim/reader.h Changed printing of line_buf to safely handle NULL pointers
libCacheSim/include/libCacheSim/macro.h Simplified macros by removing redundant FMT parameters
libCacheSim/include/libCacheSim/evictionAlgo.h Reordered and renamed several cache eviction function prototypes
libCacheSim/dataStructure/* Updated usage of std::move in splay tree implementations and fixed include guard spelling
libCacheSim/cache/* Updated printf conversion specifiers; adjusted CMake link options for improved dependency management
CMakeLists.txt Restructured module linkage and added visibility settings for symbol exports
Comments suppressed due to low confidence (2)

libCacheSim/include/libCacheSim/evictionAlgo.h:53

  • The function prototypes in this file have been significantly reordered and renamed. Ensure that the updated API design is consistently documented and that all consumers of these interfaces are updated accordingly.
cache_t *CAR_init(const common_cache_params_t ccache_params,

libCacheSim/dataStructure/minimalIncrementCBF.h:1

  • The include guard identifier has been corrected from '_MINIMAL_INCREMENR_CBF_H' to '_MINIMAL_INCREMENT_CBF_H'. Verify that this change does not conflict with any external dependencies.
#ifndef _MINIMAL_INCREMENT_CBF_H

Comment thread CMakeLists.txt Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@1a1a11a 1a1a11a changed the title fix macos build and cleanup cmake refactor: fix macos build and cleanup cmake Jun 22, 2025
Copy link
Copy Markdown
Collaborator

@haochengxia haochengxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@1a1a11a 1a1a11a merged commit 61486d6 into develop Jun 22, 2025
7 checks passed
@1a1a11a 1a1a11a deleted the 1a1a1a/macos_build branch June 22, 2025 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants