Merged
Conversation
…ncy. Simplified directory navigation and build commands by removing redundant lines and ensuring proper quoting.
1a1a11a
force-pushed
the
1a1a11a/remove_compiler_flag
branch
from
f1e1ff3 to
de39434
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR simplifies the installation script by removing hard-coded compiler flags and refactoring the workflow.
- Removed explicit compiler and CMake build options
- Improved script quoting and directory handling
- Streamlined commands with minimal changes to core logic
Comments suppressed due to low confidence (1)
scripts/install_libcachesim.sh:4
- The variable name 'SORUCE' appears to be misspelled; consider renaming it to 'SOURCE' for clarity.
SORUCE=$(readlink -f "${BASH_SOURCE[0]}")
haochengxia
approved these changes
Jun 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolve #205