Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the plugin cache creation function from create_cache to create_cache_using_plugin and updates its usage and documentation accordingly.
- Renamed
create_cachetocreate_cache_using_pluginin header, implementation, and usage inmrcProfiler.cpp - Updated related Doxygen comments to reference the new function name
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| libCacheSim/mrcProfiler/mrcProfiler.cpp | Updated call to use create_cache_using_plugin |
| libCacheSim/include/libCacheSim/plugin.h | Renamed function declaration and updated comment |
| libCacheSim/cache/plugin.c | Renamed function definition |
Comments suppressed due to low confidence (2)
libCacheSim/include/libCacheSim/plugin.h:52
- Renaming the core API function will break existing integrations. Consider adding a deprecated
create_cachealias that forwards tocreate_cache_using_pluginto maintain backward compatibility.
cache_t *create_cache_using_plugin(const char *const cache_alg_name,
libCacheSim/cache/plugin.c:93
- The renamed function
create_cache_using_pluginlacks dedicated unit tests. Consider adding tests to cover plugin-based cache initialization and error cases.
cache_t *create_cache_using_plugin(const char *const cache_alg_name,
1a1a11a
reviewed
Jul 11, 2025
| .default_ttl = 0, | ||
| .hashpower = 20, | ||
| .consider_obj_metadata = false}; | ||
| caches[i] = create_cache(params_.cache_algorithm_str, cc_params, nullptr); |
Collaborator
Author
There was a problem hiding this comment.
We can directly use create_cache_internal here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #258