Skip to content

fix some compiler issues #261

Merged
1a1a11a merged 5 commits intodevelopfrom
jason/compile_glib
Jul 14, 2025
Merged

fix some compiler issues #261
1a1a11a merged 5 commits intodevelopfrom
jason/compile_glib

Conversation

@1a1a11a
Copy link
Copy Markdown
Owner

@1a1a11a 1a1a11a commented Jul 14, 2025

some compiler complains that "main" should not be used as a variable name

  • Updated variable names in QDLP, S3FIFO, S3FIFOd, S3FIFOv0, WTinyLFU, and S3LRU eviction algorithms

changed how glib is found

  • this is needed to compile when glib is installed at user directory

1a1a11a added 2 commits July 13, 2025 20:27
…not be used as a variable name

- Updated variable names in QDLP, S3FIFO, S3FIFOd, S3FIFOv0, WTinyLFU, and S3LRU eviction algorithms to improve code readability.
- Changed 'fifo' to 'small_fifo' and 'main' to 'main_cache' for consistency across the codebase.
- Ensured that all references to cache objects are clear and descriptive, enhancing maintainability.
@1a1a11a 1a1a11a marked this pull request as ready for review July 14, 2025 00:48
@1a1a11a 1a1a11a requested a review from haochengxia as a code owner July 14, 2025 00:48
Comment thread libCacheSim/cache/eviction/QDLP.c Outdated
@1a1a11a
Copy link
Copy Markdown
Owner Author

1a1a11a commented Jul 14, 2025

updated the names @haochengxia

@1a1a11a 1a1a11a changed the title fix cmake issue when glib is not installed at default path fix some compiler issues Jul 14, 2025
Copy link
Copy Markdown
Collaborator

@haochengxia haochengxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@1a1a11a 1a1a11a merged commit deb3134 into develop Jul 14, 2025
12 checks passed
@1a1a11a 1a1a11a deleted the jason/compile_glib branch July 14, 2025 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants