Skip to content

[CLEANUP]: Remove deprecated type#276

Merged
haochengxia merged 3 commits intodevelopfrom
hxia/cleanup
Jul 21, 2025
Merged

[CLEANUP]: Remove deprecated type#276
haochengxia merged 3 commits intodevelopfrom
hxia/cleanup

Conversation

@haochengxia
Copy link
Copy Markdown
Collaborator

@haochengxia haochengxia commented Jul 21, 2025

For #273

Remove obj_id_type.

@haochengxia
Copy link
Copy Markdown
Collaborator Author

still appears in the code will not be compiled https://github.com/1a1a11a/libCacheSim/tree/develop/libCacheSim/bin/customized/fast23/compareGrouping.cpp

@1a1a11a Should we adapt these code as well?

@haochengxia haochengxia changed the title [CLEANUP] Remove deprecated type [CLEANUP]: Remove deprecated type Jul 21, 2025
@haochengxia haochengxia requested a review from Copilot July 21, 2025 16:00
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated obj_id_type parameter and related functionality from the libCacheSim library as part of cleanup work for issue #273. The changes simplify API signatures by removing an unused parameter and update associated documentation and error messages.

  • Remove obj_id_type parameter from reader initialization functions
  • Update documentation to reflect the simplified API
  • Correct error messages to reference the correct variable names

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
libCacheSim/traceReader/reader.c Fixed error message to reference correct variable name
libCacheSim/include/libCacheSim/reader.h Removed deprecated parameter from function documentation
libCacheSim/include/libCacheSim/plugin.h Updated comment to remove reference to deprecated parameter
doc/advanced_lib.md Updated code examples to remove deprecated parameter usage
doc/API.md Removed deprecated parameter from function signatures and documentation

Comment thread libCacheSim/traceReader/reader.c Outdated
@1a1a11a
Copy link
Copy Markdown
Owner

1a1a11a commented Jul 21, 2025

still appears in the code will not be compiled https://github.com/1a1a11a/libCacheSim/tree/develop/libCacheSim/bin/customized/fast23/compareGrouping.cpp

@1a1a11a Should we adapt these code as well?

let's remove it.

@haochengxia haochengxia merged commit 9646c8e into develop Jul 21, 2025
11 checks passed
@haochengxia haochengxia deleted the hxia/cleanup branch July 21, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants