[CLEANUP]: Remove deprecated type#276
Conversation
|
still appears in the code will not be compiled https://github.com/1a1a11a/libCacheSim/tree/develop/libCacheSim/bin/customized/fast23/compareGrouping.cpp @1a1a11a Should we adapt these code as well? |
There was a problem hiding this comment.
Pull Request Overview
This PR removes the deprecated obj_id_type parameter and related functionality from the libCacheSim library as part of cleanup work for issue #273. The changes simplify API signatures by removing an unused parameter and update associated documentation and error messages.
- Remove
obj_id_typeparameter from reader initialization functions - Update documentation to reflect the simplified API
- Correct error messages to reference the correct variable names
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| libCacheSim/traceReader/reader.c | Fixed error message to reference correct variable name |
| libCacheSim/include/libCacheSim/reader.h | Removed deprecated parameter from function documentation |
| libCacheSim/include/libCacheSim/plugin.h | Updated comment to remove reference to deprecated parameter |
| doc/advanced_lib.md | Updated code examples to remove deprecated parameter usage |
| doc/API.md | Removed deprecated parameter from function signatures and documentation |
let's remove it. |
For #273
Remove
obj_id_type.