Fix: documentation about 'auto' keyword in cachesim#278
Merged
haochengxia merged 2 commits into1a1a11a:developfrom Jul 24, 2025
Merged
Fix: documentation about 'auto' keyword in cachesim#278haochengxia merged 2 commits into1a1a11a:developfrom
haochengxia merged 2 commits into1a1a11a:developfrom
Conversation
haochengxia
approved these changes
Jul 24, 2025
Collaborator
|
LGTM. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the quickstart_cachesim.md docs mention that the keyword auto will "automatically generate cache sizes at 0.0001, 0.0003, 0.001, 0.003, 0.01, 0.03, 0.1, 0.3 of the working set size". However, the implementation itself uses different sizes, namely 0.001, 0.003, 0.01, 0.03, 0.1, 0.2, 0.4, 0.8, which is set in the set_cache_size function in cli_parser.c.
This PR fixes the mention in the docs and adds a comment for clarity in the codebase.