Add integrator fee#72
Open
UnDeleteRU wants to merge 10 commits into
Open
Conversation
edvardg
reviewed
Jul 13, 2026
| const order = new LimitOrderWithFee(orderInfo, makerTraits, feeExt) | ||
|
|
||
| if (feeParams.source) { | ||
| order.setSource(feeParams.source) |
There was a problem hiding this comment.
After this change createOrder silently starts embedding integrator fees and setting the source track code for keys with portal fee config - existing integrators get new behavior on upgrade without touching code. Can we call this out in the changelog/README and bump the version accordingly?
edvardg
reviewed
Jul 15, 2026
edvardg
reviewed
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
What does this PR change?
Add integrator fee
Related Issue/Ticket:
https://1inch.atlassian.net/browse/PT9-759
Testing & Verification
How was this tested?
Risk Assessment
Risk Level: