Use local provider for remote overnight runs

Author: 1jehuang

src/tui/app/commands_overnight.rs

@@ -1,5 +1,7 @@
 use super::{App, DisplayMessage};
 use crate::overnight::{OvernightCommand, OvernightStartOptions};
+use crate::provider::Provider;
+use std::sync::Arc;
 
 pub(super) fn handle_overnight_command(app: &mut App, trimmed: &str) -> bool {
     let Some(command) = crate::overnight::parse_overnight_command(trimmed) else {
@@ -20,11 +22,12 @@ pub(super) fn handle_overnight_command(app: &mut App, trimmed: &str) -> bool {
                 .map(std::path::PathBuf::from)
                 .filter(|path| path.is_dir())
                 .or_else(|| std::env::current_dir().ok());
+            let provider = overnight_provider_for_app(app);
             let options = OvernightStartOptions {
                 duration,
                 mission,
                 parent_session: app.session.clone(),
-                provider: app.provider.fork(),
+                provider,
                 registry: app.registry.clone(),
                 working_dir,
                 use_current_session: true,
@@ -53,6 +56,35 @@ fn show_overnight_help(app: &mut App) {
     ));
 }
 
+fn overnight_provider_for_app(app: &mut App) -> Arc<dyn Provider> {
+    if !app.is_remote {
+        return app.provider.fork();
+    }
+
+    // Remote-attached TUIs intentionally use NullProvider because normal turns
+    // execute in the remote backend process. `/overnight` is supervised by the
+    // launching TUI process, so it needs a real local provider instead of the
+    // remote placeholder. Restore the displayed session model when possible and
+    // otherwise fall back to the local default provider.
+    let provider: Arc<dyn Provider> = Arc::new(crate::provider::MultiProvider::new_fast());
+    if let Some(model) = app
+        .session
+        .model
+        .as_deref()
+        .map(str::trim)
+        .filter(|model| !model.is_empty() && *model != "unknown")
+        && let Err(error) = provider.set_model(model)
+    {
+        app.push_display_message(DisplayMessage::system(format!(
+            "Overnight could not restore remote model `{}` locally: {}. Using local default provider `{}` instead.",
+            model,
+            error,
+            provider.name()
+        )));
+    }
+    provider
+}
+
 fn show_overnight_status(app: &mut App) {
     match crate::overnight::latest_manifest() {
         Ok(Some(manifest)) => {