test(tui): isolate render geometry from global state

Author: 1jehuang

crates/jcode-tui/src/tui/app/tests/scroll_copy_01/part_01.rs

@@ -33,6 +33,12 @@ fn create_scroll_test_app(
     crate::tui::mermaid::clear_streaming_preview_diagram();
 
     let mut app = create_test_app();
+    if diagrams == 0 {
+        // Process-global diagrams can be registered by sibling tests after the
+        // clear above. Keep text-only geometry deterministic at the App level.
+        app.diagram_mode = crate::config::DiagramDisplayMode::Off;
+        app.diagram_pane_enabled = false;
+    }
     let content = App::build_scroll_test_content(diagrams, padding, None);
     app.display_messages = vec![
         DisplayMessage {
@@ -365,6 +371,7 @@ fn test_chat_native_scrollbar_hides_scroll_counters() {
 
 #[test]
 fn test_streaming_repaint_does_not_leave_bracket_artifact() {
+    let _render_lock = scroll_render_test_lock();
     let mut app = create_test_app();
     let backend = ratatui::backend::TestBackend::new(90, 20);
     let mut terminal = ratatui::Terminal::new(backend).expect("failed to create test terminal");
@@ -975,6 +982,7 @@ fn test_prompt_jump_ctrl_brackets() {
 #[cfg(target_os = "macos")]
 #[test]
 fn test_prompt_jump_ctrl_esc_fallback_on_macos() {
+    let _render_lock = scroll_render_test_lock();
     let (mut app, mut terminal) = create_scroll_test_app(100, 30, 1, 20);
 
     render_and_snap(&app, &mut terminal);

crates/jcode-tui/src/tui/app/tests/scroll_copy_01/part_02.rs

@@ -234,6 +234,7 @@ fn test_remote_prompt_jump_ctrl_brackets() {
 #[cfg(target_os = "macos")]
 #[test]
 fn test_remote_prompt_jump_ctrl_esc_fallback_on_macos() {
+    let _render_lock = scroll_render_test_lock();
     let (mut app, mut terminal) = create_scroll_test_app(100, 30, 1, 20);
     let rt = tokio::runtime::Runtime::new().unwrap();
     let _guard = rt.enter();

crates/jcode-tui/src/tui/app/tests/scroll_copy_02/part_02.rs

@@ -560,6 +560,11 @@ fn test_try_open_link_at_opens_clicked_url_and_sets_notice() {
 fn test_mouse_click_in_input_moves_cursor_to_clicked_position() {
     let _render_lock = scroll_render_test_lock();
     let mut app = create_test_app();
+    // A persisted first-run state can otherwise replace the composer with the
+    // suggestion welcome screen, leaving a zero-height input hit target.
+    app.push_display_message(DisplayMessage::assistant("seed transcript"));
+    app.diagram_mode = crate::config::DiagramDisplayMode::Off;
+    app.diagram_pane_enabled = false;
     app.input = "hello world".to_string();
     app.cursor_pos = app.input.len();
     app.set_centered(false);
@@ -630,6 +635,10 @@ fn test_mouse_click_in_main_chat_switches_focus_from_side_panel() {
 fn test_mouse_click_in_input_switches_focus_from_side_panel() {
     let _render_lock = scroll_render_test_lock();
     let mut app = create_test_app();
+    // Keep first-run suggestions from replacing the composer under test.
+    app.push_display_message(DisplayMessage::assistant("seed transcript"));
+    app.diagram_mode = crate::config::DiagramDisplayMode::Off;
+    app.diagram_pane_enabled = false;
     app.diff_mode = crate::config::DiffDisplayMode::Inline;
     app.diff_pane_focus = true;
     app.side_panel = crate::side_panel::SidePanelSnapshot {
@@ -678,6 +687,10 @@ fn test_mouse_click_in_input_switches_focus_from_side_panel() {
 fn test_mouse_click_in_wrapped_input_moves_cursor_to_second_visual_line() {
     let _render_lock = scroll_render_test_lock();
     let mut app = create_test_app();
+    // Keep first-run suggestions from replacing the composer under test.
+    app.push_display_message(DisplayMessage::assistant("seed transcript"));
+    app.diagram_mode = crate::config::DiagramDisplayMode::Off;
+    app.diagram_pane_enabled = false;
     app.input = "abcdefghij".to_string();
     app.cursor_pos = 0;
     app.set_centered(false);

crates/jcode-tui/src/tui/app/tests/state_model_poke_02/part_01.rs

@@ -253,6 +253,7 @@ fn test_handterm_native_scroll_client_roundtrips_over_socket() {
     use std::os::unix::net::UnixListener;
 
     let _lock = crate::storage::lock_test_env();
+    let _render_lock = scroll_render_test_lock();
     let dir = tempfile::tempdir().expect("tempdir");
     let socket_path = dir.path().join("handterm-scroll.sock");
     let listener = UnixListener::bind(&socket_path).expect("bind unix listener");