test(tui): retry inline-image materialization against parallel image-state wipes

Author: 1jehuang

crates/jcode-tui/src/tui/ui_inline_image.rs

@@ -1033,18 +1033,30 @@ mod tests {
     /// 1x1 transparent PNG used by the materialize tests below.
     const MATERIALIZE_PNG_B64: &str = "iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAYAAAAfFcSJAAAADUlEQVR42mP8z8BQDwAEhQGAhKmMIQAAAABJRU5ErkJggg==";
 
+    /// Materialize `id`, retrying against unrelated parallel tests that wipe
+    /// the process-global image state (`mermaid::clear_image_state()` runs on
+    /// diagram geometry changes, zoom, and session-picker paths). Each retry
+    /// re-stages the payload because `register_payload` is skipped while an
+    /// image is materialized and a wipe can clear both stores at once.
+    fn materialize_with_retry<F: Fn() -> bool>(id: u64, check: F) {
+        for _ in 0..100 {
+            register_payload(id, "image/png", MATERIALIZE_PNG_B64);
+            if materialize_visible(id) && check() {
+                return;
+            }
+            std::thread::sleep(std::time::Duration::from_millis(5));
+        }
+        panic!("image {id:#x} never reached the expected state despite retries");
+    }
+
     #[test]
     fn materialize_visible_probe_is_cheap_after_first_call() {
         let id = mermaid::inline_image_id("image/png", MATERIALIZE_PNG_B64);
-        register_payload(id, "image/png", MATERIALIZE_PNG_B64);
-        assert!(materialize_visible(id), "first call decodes and caches");
         // Steady state: the in-memory probe alone must report ready, without
         // needing the payload registry at all.
-        assert!(
-            mermaid::inline_image_is_materialized(id),
-            "presence probe should hit after materialization"
-        );
-        assert!(materialize_visible(id), "repeat call stays true");
+        materialize_with_retry(id, || {
+            mermaid::inline_image_is_materialized(id) && materialize_visible(id)
+        });
     }
 
     #[test]
@@ -1053,13 +1065,10 @@ mod tests {
         // materialized image has nothing to prewarm: prefetch must be a cheap
         // no-op (no panic, no scheduling) and the image stays materialized.
         let id = mermaid::inline_image_id("image/png", MATERIALIZE_PNG_B64);
-        register_payload(id, "image/png", MATERIALIZE_PNG_B64);
-        assert!(materialize_visible(id));
-        prefetch(id, 80, 10);
-        assert!(
-            mermaid::inline_image_is_materialized(id),
-            "prefetch must not disturb already-materialized state"
-        );
+        materialize_with_retry(id, || {
+            prefetch(id, 80, 10);
+            mermaid::inline_image_is_materialized(id)
+        });
     }
 
     #[test]
@@ -1068,12 +1077,7 @@ mod tests {
         // Unsupported; a materialized image must still be drawable so the
         // fallback renderers can run.
         let id = mermaid::inline_image_id("image/png", MATERIALIZE_PNG_B64);
-        register_payload(id, "image/png", MATERIALIZE_PNG_B64);
-        assert!(materialize_visible(id));
-        assert!(
-            ensure_drawable(id, 80, 10),
-            "materialized image must be drawable on non-Kitty protocols"
-        );
+        materialize_with_retry(id, || ensure_drawable(id, 80, 10));
     }
 
     #[test]