Skip to content

Commit ee6a3ec

Browse files
committed
Fix duplicate comment in redis test file
1 parent 54617c0 commit ee6a3ec

2 files changed

Lines changed: 20 additions & 10 deletions

File tree

internal/store/redis/redis_test.go

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,13 @@ func TestRedisStoreBasicOperations(t *testing.T) {
3535
if err != nil {
3636
t.Fatalf("Failed to create Redis store: %v", err)
3737
}
38-
defer store.Close()
38+
defer func() {
39+
_ = store.Close() // Test cleanup - ignore error
40+
}()
3941

4042
// Clean up any existing test data
4143
testKey := "test-key"
42-
store.Delete(testKey)
44+
_ = store.Delete(testKey) // Test cleanup - ignore error
4345

4446
// Test Set and Get
4547
testEntry := entry.New("test-value", time.Hour)
@@ -105,11 +107,13 @@ func TestRedisStoreWithTTL(t *testing.T) {
105107
if err != nil {
106108
t.Fatalf("Failed to create Redis store: %v", err)
107109
}
108-
defer store.Close()
110+
defer func() {
111+
_ = store.Close() // Test cleanup - ignore error
112+
}()
109113

110114
// Test with short TTL
111115
testKey := "ttl-key"
112-
store.Delete(testKey) // Clean up
116+
_ = store.Delete(testKey) // Test cleanup - ignore error
113117

114118
shortTTLEntry := entry.New("ttl-value", 100*time.Millisecond)
115119
err = store.Set(testKey, shortTTLEntry)
@@ -153,13 +157,15 @@ func TestRedisStoreClear(t *testing.T) {
153157
if err != nil {
154158
t.Fatalf("Failed to create Redis store: %v", err)
155159
}
156-
defer store.Close()
160+
defer func() {
161+
_ = store.Close() // Test cleanup - ignore error
162+
}()
157163

158164
// Add some entries
159165
for i := 0; i < 5; i++ {
160166
key := fmt.Sprintf("key-%d", i)
161167
entry := entry.New(fmt.Sprintf("value-%d", i), time.Hour)
162-
store.Set(key, entry)
168+
_ = store.Set(key, entry) // Test setup - ignore error
163169
}
164170

165171
// Verify entries exist

pkg/compression/compression.go

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ func (g *GzipCompressor) Compress(data []byte) ([]byte, error) {
123123
}
124124

125125
if _, err := writer.Write(data); err != nil {
126-
writer.Close()
126+
_ = writer.Close() // Ignore error on cleanup path
127127
return nil, fmt.Errorf("failed to write compressed data: %w", err)
128128
}
129129

@@ -140,7 +140,9 @@ func (g *GzipCompressor) Decompress(compressed []byte) ([]byte, error) {
140140
if err != nil {
141141
return nil, fmt.Errorf("failed to create gzip reader: %w", err)
142142
}
143-
defer reader.Close()
143+
defer func() {
144+
_ = reader.Close() // Ignore error on defer
145+
}()
144146

145147
data, err := io.ReadAll(reader)
146148
if err != nil {
@@ -175,7 +177,7 @@ func (d *DeflateCompressor) Compress(data []byte) ([]byte, error) {
175177
}
176178

177179
if _, err := writer.Write(data); err != nil {
178-
writer.Close()
180+
_ = writer.Close() // Ignore error on cleanup path
179181
return nil, fmt.Errorf("failed to write compressed data: %w", err)
180182
}
181183

@@ -192,7 +194,9 @@ func (d *DeflateCompressor) Decompress(compressed []byte) ([]byte, error) {
192194
if err != nil {
193195
return nil, fmt.Errorf("failed to create deflate reader: %w", err)
194196
}
195-
defer reader.Close()
197+
defer func() {
198+
_ = reader.Close() // Ignore error on defer
199+
}()
196200

197201
data, err := io.ReadAll(reader)
198202
if err != nil {

0 commit comments

Comments
 (0)