test: add testing to coordinates component

Author: gsiri-code

data/tests/test_cities.py

@@ -546,3 +546,34 @@ def test_update_city_sanitizes_country_code(
 
             # Verify sanitization occurred
             assert update_data[cities.COUNTRY_CODE] == 'CA'
+
+    def test_add_city_invalid_coordinates(self, sample_city_with_state):
+        """Test that add_city rejects out-of-range coordinates."""
+        sample_city_with_state[cities.COORDINATES] = {
+            cities.LATITUDE: 91,
+            cities.LONGITUDE: -89.64,
+        }
+
+        with patch('data.db_connect.create') as mock_create, \
+                patch('data.states.state_exists', return_value=True), \
+                patch('data.countries.country_exists', return_value=True):
+            with pytest.raises(ValueError, match="latitude"):
+                cities.add_city(sample_city_with_state)
+
+            mock_create.assert_not_called()
+
+    def test_update_city_invalid_coordinates(self, sample_city_with_state):
+        """Test that update_city rejects out-of-range coordinates."""
+        update_data = {
+            cities.COORDINATES: {
+                cities.LATITUDE: 39.78,
+                cities.LONGITUDE: -181,
+            }
+        }
+
+        with patch('data.cities.get_city_by_name_and_state', return_value=sample_city_with_state), \
+                patch('data.db_connect.update') as mock_update:
+            with pytest.raises(ValueError, match="longitude"):
+                cities.update_city('Springfield', 'IL', update_data)
+
+            mock_update.assert_not_called()

data/tests/test_coordinates.py

@@ -0,0 +1,69 @@
+"""
+Tests for the coordinate validation types.
+"""
+
+import pytest
+
+from data.coordinates import Coordinate, Coordinates, Latitude, Longitude
+
+
+class TestCoordinates:
+    def test_coordinate_base_is_abstract(self):
+        with pytest.raises(TypeError):
+            Coordinate(10)
+
+    def test_construct_latitude(self):
+        latitude = Latitude(39.78)
+        assert isinstance(latitude, Latitude)
+
+    def test_construct_longitude(self):
+        longitude = Longitude(-89.64)
+        assert isinstance(longitude, Longitude)
+
+    def test_construct_latitude_bad_type(self):
+        with pytest.raises(TypeError):
+            Latitude("39.78")
+
+    def test_construct_longitude_bad_type(self):
+        with pytest.raises(TypeError):
+            Longitude("-89.64")
+
+    def test_construct_latitude_too_small(self):
+        with pytest.raises(ValueError, match="latitude"):
+            Latitude(-91)
+
+    def test_construct_latitude_too_large(self):
+        with pytest.raises(ValueError, match="latitude"):
+            Latitude(91)
+
+    def test_construct_longitude_too_small(self):
+        with pytest.raises(ValueError, match="longitude"):
+            Longitude(-181)
+
+    def test_construct_longitude_too_large(self):
+        with pytest.raises(ValueError, match="longitude"):
+            Longitude(181)
+
+    def test_coordinate_string_conversion(self):
+        assert str(Latitude(39.78)) == "39.78"
+
+    def test_coordinate_float_conversion(self):
+        assert float(Longitude(-89.64)) == -89.64
+
+    def test_coordinates_from_dict(self):
+        coordinates = Coordinates.from_dict(
+            {"latitude": 39.78, "longitude": -89.64}
+        )
+        assert coordinates.to_dict() == {"latitude": 39.78, "longitude": -89.64}
+
+    def test_coordinates_bad_container_type(self):
+        with pytest.raises(TypeError):
+            Coordinates.from_dict("39.78,-89.64")
+
+    def test_coordinates_missing_latitude(self):
+        with pytest.raises(ValueError, match="Missing latitude"):
+            Coordinates.from_dict({"longitude": -89.64})
+
+    def test_coordinates_missing_longitude(self):
+        with pytest.raises(ValueError, match="Missing longitude"):
+            Coordinates.from_dict({"latitude": 39.78})