Code actions are unstable with TypeScript and Vue on save

[simensol]

I would love to use this extension for my TypeScript and Vue codebase. However, enabling the source.fixAll.blocksort is not working or is very unstable. Some observations:

1. I have to explicitly set "source.fixAll": "explicit" to make source.fixAll.blocksort run successfully on save:

    "[vue]": {
        "editor.codeActionsOnSave": {
            "source.fixAll": "explicit", // Required
            "source.fixAll.blocksort": "explicit",
            "source.fixAll.eslint": "explicit",
            "source.fixAll.stylelint": "explicit",
            "source.organizeImports": "never"
        },
        "editor.defaultFormatter": "esbenp.prettier-vscode",
        "editor.formatOnSave": true
    }

2. I often experience the code action to get stuck on Sort all annotated Blocks on save:

3. The manual blocksort action mostly works even if the on save code action doesn't work.

4. I often have to save twice for the blocksort to sort on save; the first time I save, the formatter and other code actions seem to run, but the blocksort code action seems to require an additional save.

5. The on save code action is more stable with TypeScript than Vue, but the first issue (source.fixAll required) also applies to TypeScript.

[1nVitr0]

I know that having both code actions on save and format on save enabled used to have some issues, though I haven't looked into that in a while. Thanks for the issue, that feature was never really battle-tested anyway, your observations help a lot!

[1nVitr0]

@simensol I am finally getting around to diving into this issue a little deeper. There are multiple issues with the current implementation, I presume it will require quite some work to fix everything. Sorry for the delay, I would guess the fix will be ready in 1-2 weeks, though it might take longer.

[1nVitr0]

Didn't mean to close this. Though the current update might fix the issue that the code actions on save are not working, I haven't done any real performance improvements.

[simensol]

@1nVitr0 Thank you for your work on this. I will test it on my site and share any feedback.

[simensol]

@1nVitr0 I am still encountering issues with code actions on save for both Vue and TypeScript files in v2.4.2. Despite my efforts, I have not been able to identify a consistent pattern. Some blocks work without any problems, while others randomly cause the code actions on save to hang.