Skip to content

Remove configuration from XML, use PhpFileLoader for the container configuration#318

Merged
bytehead merged 2 commits into1up-lab:mainfrom
bartbrouwer:bugfix/Prefer-PhpFileLoader-Over-Xml
Dec 3, 2025
Merged

Remove configuration from XML, use PhpFileLoader for the container configuration#318
bytehead merged 2 commits into1up-lab:mainfrom
bartbrouwer:bugfix/Prefer-PhpFileLoader-Over-Xml

Conversation

@bartbrouwer
Copy link
Copy Markdown
Contributor

No description provided.

@skmedix
Copy link
Copy Markdown

skmedix commented Dec 2, 2025

Continuing discussion from #313 (comment)

I think it would be better to remove the XML configurations completely

@bartbrouwer bartbrouwer changed the title Prefer in DI the PhpFileLoader over the XmlFileLoader Remove configuration from XML, use PhpFileLoader for the container configuration Dec 2, 2025
@bartbrouwer
Copy link
Copy Markdown
Contributor Author

@bytehead can you review this PR?

@bytehead
Copy link
Copy Markdown
Member

bytehead commented Dec 3, 2025

I'll do!

@bytehead bytehead added the bug label Dec 3, 2025
@bytehead bytehead merged commit fab1eee into 1up-lab:main Dec 3, 2025
18 checks passed
@bytehead
Copy link
Copy Markdown
Member

bytehead commented Dec 3, 2025

Thank you @bartbrouwer!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to generate ConfigBuilder for extension Oneup\FlysystemBundle\DependencyInjection\OneupFlysystemExtension

3 participants