Skip to content

WIP: Google AI agent and classifier#170

Closed
slavb18 wants to merge 5 commits into
2FastLabs:mainfrom
iconicompany:main
Closed

WIP: Google AI agent and classifier#170
slavb18 wants to merge 5 commits into
2FastLabs:mainfrom
iconicompany:main

Conversation

@slavb18

@slavb18 slavb18 commented Dec 24, 2024

Copy link
Copy Markdown

Issue number:

Summary

Changes

Provide agent and classifier for GoogleGenerativeAI client

User experience

User experience not changed

Checklist

If your change doesn't seem to apply, please leave them unchecked.

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@cornelcroi

Copy link
Copy Markdown
Collaborator

Thank you @slavb18 for the PR.

1 - Could you create a documentation page for the classifier and for the agent with some code examples on how to create an agent/classifier with different options?
You can use this one as example.
2 - Also, maybe you could adding a script with a couple of agents (google agents and/or other agents) and google classifier somewhere in example folder. Examples are always a good.

@cornelcroi

Copy link
Copy Markdown
Collaborator

Thanks for the update.
In the documentation I see the python version but in the PR I see only changes to typescript.
Do you plan to add the python version to this PR?

@slavb18

slavb18 commented Dec 24, 2024

Copy link
Copy Markdown
Author

Thanks for the update.
In the documentation I see the python version but in the PR I see only changes to typescript.
Do you plan to add the python version to this PR?

Thank you for pointing that out! I prefer to submit the TypeScript version only, if this is applicable, to keep the scope of the PR focused. Additionally, since there is no toolagent support currently, it would need to be added first before implementing the Python version. Let me know how you’d like to proceed!

@cornelcroi

Copy link
Copy Markdown
Collaborator

Ok, sure.
In this case I would suggest to delete the <TabItem label="Python" icon="seti:python"> from the doc, in this case it will be a single tab with typescript code.

@cornelcroi

cornelcroi commented Dec 24, 2024

Copy link
Copy Markdown
Collaborator

For python we will publish in the following days a simplified way to use tools with agents.
You can use tools today but it is a bit ugly the code required, so we simplified.
You could wait for it, and then create the python version with tools support also.

@slavb18 slavb18 changed the title Google AI agent and classifier WIP: Google AI agent and classifier Dec 25, 2024
@slavb18
slavb18 marked this pull request as draft December 25, 2024 08:10
@cornelcroi

Copy link
Copy Markdown
Collaborator

Hey @slavb18, any updates on this?

@slavb18

slavb18 commented Jan 23, 2025

Copy link
Copy Markdown
Author

Hey @slavb18, any updates on this?

I am currently testing tool agents in #96 (OpenAI) to implement them here

@cornelcroi

Copy link
Copy Markdown
Collaborator

Closing this draft PR — it has been open for 552 days with no activity in 522 days. Gemini support is being addressed by the more recent and complete #482. Thank you for the early work on Gemini support!

@cornelcroi cornelcroi closed this Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants