Skip to content

refactor(protocol): prune grpc-gateway related proto #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
317787106 wants to merge 5 commits into from
Closed

refactor(protocol): prune grpc-gateway related proto #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04821b8
prune proto
317787106 Apr 17, 2026
52e1d1a
remove reduant whitespace
317787106 Apr 23, 2026
56a6249
Merge branch 'develop' into feature/prune_proto
317787106 Apr 28, 2026
ec2dbb7
remove all option go_package in proto
317787106 Apr 29, 2026
6df6132
support go get for proto
317787106 Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
394 changes: 1 addition & 393 deletions protocol/src/main/protos/api/api.proto
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion protocol/src/main/protos/api/zksnark.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import "core/Tron.proto";

option java_package = "org.tron.api"; //Specify the name of the package that generated the Java file
option java_outer_classname = "ZksnarkGrpcAPI"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/api";
option go_package = "github.com/tronprotocol/protocol/api";

service TronZksnark {
rpc CheckZksnarkProof (ZksnarkRequest) returns (ZksnarkResponse) {
Expand Down
3 changes: 1 addition & 2 deletions protocol/src/main/protos/core/Discover.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,9 @@ syntax = "proto3";

package protocol;


option java_package = "org.tron.protos"; //Specify the name of the package that generated the Java file
option java_outer_classname = "Discover"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core";

message Endpoint {
bytes address = 1;
Expand Down
3 changes: 1 addition & 2 deletions protocol/src/main/protos/core/Tron.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ import "core/contract/common.proto";

package protocol;


option java_package = "org.tron.protos"; //Specify the name of the package that generated the Java file
option java_outer_classname = "Protocol"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core";

enum AccountType {
Normal = 0;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/TronInventoryItems.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos"; //Specify the name of the package that generated the Java file
option java_outer_classname = "TronInventoryItems"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core";

message InventoryItems {
int32 type = 1;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/account_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "Contract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

import "core/Tron.proto";

Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/asset_issue_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "AssetIssueContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

message AssetIssueContract {
string id = 41;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/balance_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "FreezeBalanceContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

import "core/contract/common.proto";

Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/common.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "common"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

enum ResourceCode {
BANDWIDTH = 0x00;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/exchange_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "ExchangeCreateContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

message ExchangeCreateContract {
bytes owner_address = 1;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/market_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ syntax = "proto3";
package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

message MarketSellAssetContract {
bytes owner_address = 1;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/proposal_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "ProposalApproveContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

message ProposalApproveContract {
bytes owner_address = 1;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/shield_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "ShieldedTransferContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

@cubic-dev-ai cubic-dev-ai Bot Apr 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Remove the go_package option; this file is meant to be part of the proto cleanup that strips Go-generation metadata.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At protocol/src/main/protos/core/contract/shield_contract.proto, line 7:

<comment>Remove the `go_package` option; this file is meant to be part of the proto cleanup that strips Go-generation metadata.</comment>

<file context>
@@ -4,6 +4,7 @@ package protocol;
 
 option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
 //option java_outer_classname = "ShieldedTransferContract"; //Specify the class name of the generated Java file
+option go_package = "github.com/tronprotocol/protocol/core/contract";
 
 // for shielded transaction
</file context>


// for shielded transaction

Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/smart_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "CreateSmartContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

@cubic-dev-ai cubic-dev-ai Bot Apr 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P3: Remove the go_package option here; it contradicts the proto cleanup and keeps this contract proto generateable as Go.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At protocol/src/main/protos/core/contract/smart_contract.proto, line 7:

<comment>Remove the `go_package` option here; it contradicts the proto cleanup and keeps this contract proto generateable as Go.</comment>

<file context>
@@ -4,6 +4,7 @@ package protocol;
 
 option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
 //option java_outer_classname = "CreateSmartContract"; //Specify the class name of the generated Java file
+option go_package = "github.com/tronprotocol/protocol/core/contract";
 
 import "core/Tron.proto";
</file context>


import "core/Tron.proto";

Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/storage_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "BuyStorageBytesContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

@cubic-dev-ai cubic-dev-ai Bot Apr 29, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: Remove this go_package option. It keeps Go stub generation enabled for this proto, which contradicts the cleanup.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At protocol/src/main/protos/core/contract/storage_contract.proto, line 7:

<comment>Remove this `go_package` option. It keeps Go stub generation enabled for this proto, which contradicts the cleanup.</comment>

<file context>
@@ -4,6 +4,7 @@ package protocol;
 
 option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
 //option java_outer_classname = "BuyStorageBytesContract"; //Specify the class name of the generated Java file
+option go_package = "github.com/tronprotocol/protocol/core/contract";
 
 message BuyStorageBytesContract {
</file context>


message BuyStorageBytesContract {
bytes owner_address = 1;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/vote_asset_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "VoteAssetContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

message VoteAssetContract {
bytes owner_address = 1;
Expand Down
2 changes: 1 addition & 1 deletion protocol/src/main/protos/core/contract/witness_contract.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package protocol;

option java_package = "org.tron.protos.contract"; //Specify the name of the package that generated the Java file
//option java_outer_classname = "WitnessCreateContract"; //Specify the class name of the generated Java file
option go_package = "github.com/tronprotocol/grpc-gateway/core";
option go_package = "github.com/tronprotocol/protocol/core/contract";

message WitnessCreateContract {
bytes owner_address = 1;
Expand Down
Empty file removed protocol/src/main/protos/core/tron/account.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/block.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/delegated_resource.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/p2p.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/proposal.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/transaction.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/vote.proto
View file
Open in desktop
Empty file.
Empty file removed protocol/src/main/protos/core/tron/witness.proto
View file
Open in desktop
Empty file.
Loading