Skip to content

Commit 949c423

Browse files
committed
[Binaural] Minor refactoring
1 parent 0d7f6c7 commit 949c423

3 files changed

Lines changed: 18 additions & 18 deletions

File tree

3dti_Toolkit/BinauralSpatializer/Listener.cpp

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ namespace Binaural
3535
listenerHeadRadius{_listenerHeadRadius},
3636
listenerILDAttenutationDB{ ILDATTENUATION },
3737
enableDirectionality {false, false},
38-
anechoicDirectionalityAttenuation{0.0f, 0.0f},
39-
reverbDirectionalityAttenuation{ 0.0f, 0.0f }
38+
anechoicDirectionalityLinearAttenuation{0.0f, 0.0f},
39+
reverbDirectionalityLinearAttenuation{ 0.0f, 0.0f }
4040
{
4141
std::unique_ptr<CHRTF> a(new CHRTF(this)); // HRTF of listener
4242
listenerHRTF = std::move(a);
@@ -222,53 +222,53 @@ namespace Binaural
222222
}
223223
if (ear == Common::T_ear::LEFT)
224224
{
225-
anechoicDirectionalityAttenuation.left = std::pow(10, _directionalityAttenuation / 20);
226-
reverbDirectionalityAttenuation.left = CalculateReverbDirectionalityAttenuation(_directionalityAttenuation);
225+
anechoicDirectionalityLinearAttenuation.left = std::pow(10, _directionalityAttenuation / 20);
226+
reverbDirectionalityLinearAttenuation.left = CalculateReverbDirectionalityLinearAttenuation(_directionalityAttenuation);
227227
}
228228
if (ear == Common::T_ear::RIGHT)
229229
{
230-
anechoicDirectionalityAttenuation.right = std::pow(10, _directionalityAttenuation / 20);
231-
reverbDirectionalityAttenuation.right = CalculateReverbDirectionalityAttenuation(_directionalityAttenuation);
230+
anechoicDirectionalityLinearAttenuation.right = std::pow(10, _directionalityAttenuation / 20);
231+
reverbDirectionalityLinearAttenuation.right = CalculateReverbDirectionalityLinearAttenuation(_directionalityAttenuation);
232232
}
233233
}
234234

235235
float CListener::GetAnechoicDirectionalityAttenuation_dB(Common::T_ear ear) const
236236
{
237237
if (ear == Common::T_ear::LEFT)
238-
return 20 * std::log(anechoicDirectionalityAttenuation.left);
238+
return 20 * std::log(anechoicDirectionalityLinearAttenuation.left);
239239
if (ear == Common::T_ear::RIGHT)
240-
return 20 * std::log(anechoicDirectionalityAttenuation.right);
240+
return 20 * std::log(anechoicDirectionalityLinearAttenuation.right);
241241
return -1.0f;
242242
}
243243

244244
float CListener::GetAnechoicDirectionalityLinearAttenuation(Common::T_ear ear) const
245245
{
246246
if (ear == Common::T_ear::LEFT)
247-
return anechoicDirectionalityAttenuation.left;
247+
return anechoicDirectionalityLinearAttenuation.left;
248248
if (ear == Common::T_ear::RIGHT)
249-
return anechoicDirectionalityAttenuation.right;
249+
return anechoicDirectionalityLinearAttenuation.right;
250250
return -1.0f;
251251
}
252252

253253
float CListener::GetReverbDirectionalityAttenuation_dB(Common::T_ear ear) const
254254
{
255255
if (ear == Common::T_ear::LEFT)
256-
return 20 * std::log(reverbDirectionalityAttenuation.left);
256+
return 20 * std::log(reverbDirectionalityLinearAttenuation.left);
257257
if (ear == Common::T_ear::RIGHT)
258-
return 20 * std::log(reverbDirectionalityAttenuation.right);
258+
return 20 * std::log(reverbDirectionalityLinearAttenuation.right);
259259
return -1.0f;
260260
}
261261

262262
float CListener::GetReverbDirectionalityLinearAttenuation(Common::T_ear ear) const
263263
{
264264
if (ear == Common::T_ear::LEFT)
265-
return reverbDirectionalityAttenuation.left;
265+
return reverbDirectionalityLinearAttenuation.left;
266266
if (ear == Common::T_ear::RIGHT)
267-
return reverbDirectionalityAttenuation.right;
267+
return reverbDirectionalityLinearAttenuation.right;
268268
return -1.0f;
269269
}
270270

271-
float CListener::CalculateReverbDirectionalityAttenuation(float directionalityExtend_dB)
271+
float CListener::CalculateReverbDirectionalityLinearAttenuation(float directionalityExtend_dB)
272272
{
273273

274274
float angle_rad = 0;

3dti_Toolkit/BinauralSpatializer/Listener.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ class CHRTF;
217217
float CalculateDirectionalityLinearAttenuation(float directionalityExtend, float angleToForwardAxis_rad);
218218

219219
// Calculates reverb directionality linear attenuation
220-
float CalculateReverbDirectionalityAttenuation(float directionalityExtend_dB);
220+
float CalculateReverbDirectionalityLinearAttenuation(float directionalityExtend_dB);
221221

222222
// Reset HRTF
223223
void ResetHRTF();
@@ -238,8 +238,8 @@ class CHRTF;
238238

239239
float listenerILDAttenutationDB; // Attenuation to apply when the ILD is in use (HighPerformance)
240240

241-
Common::CEarPair<float> anechoicDirectionalityAttenuation; // Max value for directionality attenuation in dBs for each channel
242-
Common::CEarPair<float> reverbDirectionalityAttenuation; // Max value for directionality attenuation in dBs for each channel
241+
Common::CEarPair<float> anechoicDirectionalityLinearAttenuation; // Max value for directionality attenuation in dBs for each channel
242+
Common::CEarPair<float> reverbDirectionalityLinearAttenuation; // Max value for directionality attenuation in dBs for each channel
243243
Common::CEarPair<bool> enableDirectionality; // True when current settings for directionality will be applied to each channel (left or right)
244244

245245
friend class CHRTF; //Friend Class definition
228 KB
Binary file not shown.

0 commit comments

Comments
 (0)