Sphinx 8 support update#276
Open
dmarteau wants to merge 3 commits into
Open
Conversation
1 task
dmarteau
force-pushed
the
update-sphinx-8
branch
2 times, most recently
from
060bf44 to
9061465
Compare
Gustry
approved these changes
May 12, 2025
Contributor
Gustry
left a comment
Gustry
left a comment
There was a problem hiding this comment.
LGTM, thanks.
Can you backport to lizmap_3_8 branch ? Thanks
Contributor
|
Note, I think the build on the gitlab side should be checked. |
Gustry
reviewed
Jun 16, 2025
Contributor
Gustry
left a comment
Gustry
left a comment
There was a problem hiding this comment.
Can you check the commit history, it seems there are 2 commits from another PR which has been merged here ?
Did the build has been checked on GitLab, with the correct versions used ?
| * Since |qgis_3|, you can use QGIS expressions, in your labels for instance. You can create automatic source label | ||
| according to visible layers following this example on the | ||
| `QGIS documentation <https://docs.qgis.org/latest/en/docs/user_manual/print_composer/composer_items/composer_label.html#id4>`_. | ||
| according to visible layers following `this example on the QGIS documentation <https://docs.qgis.org/latest/en/docs/user_manual/print_composer/composer_items/composer_label.html#id4>`_. |
Contributor
There was a problem hiding this comment.
Suggested change
| according to visible layers following `this example on the QGIS documentation <https://docs.qgis.org/latest/en/docs/user_manual/print_composer/composer_items/composer_label.html#id4>`_. | |
| according to visible layers following | |
| `this example on the QGIS documentation <https://docs.qgis.org/latest/en/docs/user_manual/print_composer/composer_items/composer_label.html#id4>`_. |
The line seems too long ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to sphinx 8.