[Bugfix] Add upgrade script for short link permalink#6905
Open
mind84 wants to merge 1 commit into
Open
Conversation
mind84
added
jelix
sponsored development
mind84
force-pushed
the
permalink_update_installer
branch
from
1a83ca4 to
36ac99e
Compare
rldhont
reviewed
Jun 3, 2026
Comment on lines
+6
to
+7
| '3.10.0-rc.1', | ||
| '3.10.0', |
Collaborator
There was a problem hiding this comment.
Suggested change
| '3.10.0-rc.1', | |
| '3.10.0', | |
| '3.10.0-pre', | |
| '3.10.0-rc.2', | |
| '3.10.0', |
-rc.1 is already passed.
The actual is -pre
The futur is -rc.2 and .0
@laurentj are these target versions rights ?
Comment on lines
+13
to
+18
| // Adding permalink table | ||
| if ($this->firstDbExec()) { | ||
| // Add permalink table | ||
| $this->useDbProfile('jauth'); | ||
| $this->execSQLScript('sql/lizpermalink'); | ||
| } |
Collaborator
There was a problem hiding this comment.
I think, you can merge it with admin/install/upgrade_permalink.php to keep only one upgrade_permalink.php file.
@laurentj What do you think about this?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes #6765
@laurentj there are a couple of things that aren't completely clear to me on Jelix upgrade module logic:
variable
$targetVersionsAs far as I understand, if the current upgrading version matches one of the version listed in this variable, then the upgrade script may be executed, depending on other subsequent checks. On the other hand, if the version doesn't match, the script never runs.
variable
$dateWhat is the purpose of this field?
In general, is there a way to force a module to update?
I updated Lizmap to version
3.10.0-rc.1, but I forgot to add theupgrade_permalinkscript. I tried adding it later and then executeinstaller.php, but it seems there's no way to run the script once the main module has been updated.Thanks for the support!
Funded by Faunalia