Skip to content

[Bugfix] Add upgrade script for short link permalink #6905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mind84 wants to merge 1 commit into
base: master
Choose a base branch
from
+23 −2
Open

[Bugfix] Add upgrade script for short link permalink #6905

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lizmap/modules/admin/install/upgrade_permalink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,10 @@
class adminModuleUpgrader_permalink extends jInstallerModule
{
public $targetVersions = array(
'3.10',
'3.10.0-rc.1',
'3.10.0',
Comment on lines +6 to +7
Copy link
Copy Markdown
Collaborator

@rldhont rldhont Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'3.10.0-rc.1',
'3.10.0',
'3.10.0-pre',
'3.10.0-rc.2',
'3.10.0',

-rc.1 is already passed.
The actual is -pre
The futur is -rc.2 and .0

@laurentj are these target versions rights ?

);
public $date = '2026-05-13'; // original:'2023-01-06'
public $date = '2026-05-13';

public function install()
{
Expand Down
20 changes: 20 additions & 0 deletions lizmap/modules/lizmap/install/upgrade_permalink.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
<?php

class lizmapModuleUpgrader_permalink extends jInstallerModule
{
public $targetVersions = array(
'3.10.0-rc.1',
'3.10.0',
);
public $date = '2026-05-26';

public function install()
{
// Adding permalink table
if ($this->firstDbExec()) {
// Add permalink table
$this->useDbProfile('jauth');
$this->execSQLScript('sql/lizpermalink');
}
Comment on lines +13 to +18
Copy link
Copy Markdown
Collaborator

@rldhont rldhont Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, you can merge it with admin/install/upgrade_permalink.php to keep only one upgrade_permalink.php file.

@laurentj What do you think about this?

}
}
Loading