Updating onfailed test to align with removal of openresty headers from APIcast midstream

Author: cathal-bailey

testsuite/tests/apicast/policy/on_failed/test_onfailed.py

@@ -19,7 +19,7 @@
 def failing_chain(on_failed_policy) -> tuple:
     """returns a policy chain that fails the execution
     made by a non-existent policy and on_failed policy"""
-    return (rawobj.PolicyConfig("invalid_policy", {}), on_failed_policy)
+    return (on_failed_policy, rawobj.PolicyConfig("invalid_policy", {}))
 
 
 @pytest.fixture
@@ -54,7 +54,7 @@ def status_code(chain_name, on_failed_configuration) -> int:
 
 @backoff.on_predicate(
     backoff.fibo,
-    lambda response: response.headers.get("server") not in ("openresty", "envoy"),
+    lambda response: response.status_code not in (200, 503, 500),
     max_tries=8,
     jitter=None,
 )
@@ -72,4 +72,3 @@ def test_on_failed_policy(application, status_code):
 
     response = make_request(api_client)
     assert response.status_code == status_code
-    assert response.headers["server"] in ("openresty", "envoy")