Fix billing tests to pass if default provider id != 2#1021
Merged
Conversation
cathal-bailey
previously approved these changes
Mar 25, 2026
mastastny
requested changes
Apr 21, 2026
mastastny
left a comment
mastastny
left a comment
Collaborator
There was a problem hiding this comment.
In the test_mail_completed_payment there is subject hardcoded to default tenant with name "Provider Name", so if we use private_tenant, the test fails. I would change it to:
subject=f"{provider_account['org_name']} API - Payment completed"
Also for the private_tenant the normalize_url function doesn't work well and the replacement should be changed from this:("3scale-admin", "3scale") to this: ("-admin.", ".").
mdujava
force-pushed
the
billing_default_customer.id
branch
2 times, most recently
from
April 23, 2026 08:48
d9ad2e4 to
5aecee3
Compare
mastastny
previously approved these changes
Apr 23, 2026
mdujava
force-pushed
the
billing_default_customer.id
branch
2 times, most recently
from
May 14, 2026 10:27
5afbb5d to
162acb1
Compare
Member
Author
|
when resolving conflict I wrongly reverted one function |
mastastny
approved these changes
May 15, 2026
mdujava
force-pushed
the
billing_default_customer.id
branch
from
May 18, 2026 08:27
162acb1 to
cc5a417
Compare
mastastny
approved these changes
May 18, 2026
mdujava
force-pushed
the
billing_default_customer.id
branch
from
June 18, 2026 13:28
cc5a417 to
ddd7ce2
Compare
cathal-bailey
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.