Add backoff retry for RHSSO and Content Limits tests #1022
Closed
cathal-bailey wants to merge 1 commit into
Closed
Add backoff retry for RHSSO and Content Limits tests #1022cathal-bailey wants to merge 1 commit into
cathal-bailey wants to merge 1 commit into
Conversation
cathal-bailey
force-pushed
the
rhsso-race-condition-fix
branch
from
March 30, 2026 12:17
eeda68b to
41d1e2d
Compare
cathal-bailey
marked this pull request as ready for review
March 30, 2026 12:21
- Add backoff decorator to staging_client fixture
- Retry on 404 status (config not loaded yet)
- Should fix timing issues in CI/Jenkins where APIcast staging
hasn't polled for new OIDC configuration yet
- Adding conftest.py for test_payload limits race condition
Fix formatting
Adding conftest.py file for content_limits tests. Adding backoff retry for these tests.
cathal-bailey
force-pushed
the
rhsso-race-condition-fix
branch
from
March 31, 2026 10:08
41d1e2d to
e072390
Compare
cathal-bailey
changed the title
mdujava
reviewed
Apr 8, 2026
| @@ -14,6 +15,21 @@ def staging_client(api_client): | |||
| """ | |||
| client = api_client() | |||
Member
There was a problem hiding this comment.
There should be default retry on 503 and 404
https://github.com/3scale-qe/3scale-api-python/blob/32de76d9eee8fee81ec3ed9876eaea7d4806338d/threescale_api/utils.py#L56
maybe better is to parametrize this fixture or just create api_client in a tests so auth is not set to None, and then internal retry should work
Collaborator
Author
|
Opened #1024 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@backoffdecorator tostaging_clientfixturepayload_limits, flaky on Jenkins pipeline