Test Updates to Align with Header Removal from APIcast Midstream

[cathal-bailey]

• APIcast midstream update removes the Server header from HTTP responses. This breaks tests that rely on checking headers to confirm APIcast is responding.
• Update to the backoff mechanism to look for valid response code rather than server header. Ensures backoff logic remains in place and working, in case it is needed.
• test_do_not_send_openresty_version.py‎ also affected by midstream change.
• Test now verifies that no server header or version information is disclosed anywhere.

[mdujava]

are there any upstream changes or jira issue that shows this is expected change?

[cathal-bailey]

are there any upstream changes or jira issue that shows this is expected change?

• Yes, headers were explicitly removed here https://gitlab.cee.redhat.com/3scale/apicast-midstream/-/merge_requests/722.

• https://redhat.atlassian.net/browse/THREESCALE-14703 - the relevant Jira issue

[mdujava]

https://redhat.atlassian.net/browse/THREESCALE-4745

[mastastny]

There is bug. In the test where you are waiting for the 503, it can pass when it gets 200, then the test will fail on the wrong status code, but the only issue is that the test didn't wait enough time to load the configuration.

I also don't like that the range of the status codes is hardcoded. If there isn't other way how to detect that configuration is loaded, I would at least test the backoff against fixture status_code and set it to something, that doesn't collide with standard status codes (e.g 418) .

[cathal-bailey]

I could set a global variable expected_code returned from fixture status_code, then retry while response.status_code != expected_code? Then when retry passes, the response code will be the correct one

[mastastny]

I'm not sure how do you want set the global variable, but test response.status_code against expected_code seems like good approach to me. I would personally refactor make_request function, so it accepts status code as parameter, wrap return api_client.get("/") by a nested function and anotate that nested function by backoff with the correct condition.