Add tests for the bot protection of the admin portal#1034
Open
mastastny wants to merge 1 commit into
Open
Conversation
mdujava
requested changes
May 11, 2026
Member
mdujava
left a comment
mdujava
left a comment
There was a problem hiding this comment.
PR took subject from wrong commit
mastastny
changed the title
mdujava
previously approved these changes
May 12, 2026
mastastny
dismissed
mdujava’s stale review
The merge-base changed after approval.
Member
|
@mastastny rebase pls |
dhlavac
reviewed
May 12, 2026
| navigator.navigate(AdminBotProtection).disable_protection() | ||
|
|
||
|
|
||
| def test_admin_login_blocked_by_recaptcha(navigator): |
Member
There was a problem hiding this comment.
not applicable to all versions of 3scale, please add for versions lower than 2.16
Member
There was a problem hiding this comment.
this bot protection is different new in alpha, so no need for backporting to 2.16?
Collaborator
Author
There was a problem hiding this comment.
The feature has been there since 2.16.0, but we officially support it since 2.16.4, so from my point of view it can be backported, but it's not necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build on top of PR #1033