Fix for test_edit_tenant failure triggered by widgetastic fill() method#1054
Fix for test_edit_tenant failure triggered by widgetastic fill() method#1054cathal-bailey wants to merge 1 commit into
Conversation
|
Is this the only time Maybe its worth to check if element is defined same way as other inputs (without this problem), if there are differences and maybe debounc might sneak some data after selenium fill, and react state combine them ... |
No other tests are using the There are some other tests using I don't believe we've seen any fails from the other tests yet. I suspect the failures in |
Updates based on comments
806edda to
b88b407
Compare
|
as its same fill followed by button click in both tests, I would suspect that tenant form webpage js might be doing something different; Also I have seen that there are 2 different strategies for fill, one of which waits on some kind of presence on webpage so maybe we just need to update which strategy to use |
TextInput.fill()method is appending text instead of replacing the existing value in the input field, even though it's supposed to clear and replace by default. This is causingtest_edit_tenantto fail persistently.replace()method has been added to tenant.py, alongside the existingupdate()methodreplace()accessed the element directly through selenium and forcesself.org_nameto clear before updating it, which resolves the failure