Fapi advanced#927
Open
mastastny wants to merge 6 commits into
Open
Conversation
mdujava
reviewed
Jun 4, 2025
mastastny
marked this pull request as ready for review
June 5, 2025 12:50
mdujava
requested changes
Jun 10, 2025
mdujava
requested changes
Jun 13, 2025
mastastny
marked this pull request as draft
June 18, 2025 12:42
mdujava
previously approved these changes
Jun 19, 2025
mdujava
previously requested changes
Jun 26, 2025
Member
|
@mastastny any update there ? |
mastastny
force-pushed
the
fapi_advanced
branch
from
April 13, 2026 16:18
be0bd21 to
8f27a88
Compare
cathal-bailey
previously approved these changes
Apr 15, 2026
mastastny
force-pushed
the
fapi_advanced
branch
from
April 20, 2026 13:18
c742ad2 to
4a6c9c2
Compare
Collaborator
Author
@dhlavac waiting for review |
cathal-bailey
previously approved these changes
May 13, 2026
Add update_client() to Realm to merge config into an existing Keycloak client (Zync already creates it via OIDC sync, so create_client() would 409). Fix fapi_sso_client to depend on application to avoid a race with Zync, and use blame() for fapi_sso_client_id to prevent ID collisions between runs.
Replace custom FapiClient with FapiMtlsAuth — a standard request auth object that retrieves a certificate-bound token per request. Use application.api_client(cert=...) for mTLS calls, consistent with the rest of the testsuite. Add fapi_client_invalid fixture to encapsulate the negative test case.
mdujava
reviewed
Jul 21, 2026
Comment on lines
+10
to
+11
| def _fallback(value, default): | ||
| return default if value is None else value |
Member
There was a problem hiding this comment.
not sure if it should be in utils, and not here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.