THREESCALE-10619 Increase default password to 23 characters

pkg/3scale/amp/component/backend_options.go

@@ -143,5 +143,5 @@ func DefaultSystemBackendUsername() string {
 }
 
 func DefaultSystemBackendPassword() string {
-	return oprand.String(8)
+	return oprand.GenerateRandomPasswordHash()
 }

pkg/3scale/amp/component/system_options.go

@@ -137,7 +137,7 @@ func DefaultRecaptchaPrivatekey() string {
 }
 
 func DefaultBackendSharedSecret() string {
-	return oprand.String(8)
+	return oprand.String(16)
 }
 
 func DefaultEventHooksURL() string {
@@ -163,15 +163,15 @@ func DefaultSystemMasterUsername() string {
 }
 
 func DefaultSystemMasterPassword() string {
-	return oprand.String(8)
+	return oprand.GenerateRandomPasswordHash()
 }
 
 func DefaultSystemAdminUsername() string {
 	return "admin"
 }
 
 func DefaultSystemAdminPassword() string {
-	return oprand.String(8)
+	return oprand.GenerateRandomPasswordHash()
 }
 
 func DefaultSystemAdminAccessToken() string {

pkg/crypto/rand/rand.go

@@ -37,3 +37,16 @@ func StringWithCharset(length int, charset string) string {
 
 	return string(result)
 }
+
+// GenerateRandomPasswordHash generates a hash of a random ASCII password
+// 5char-5char-5char-5char
+// Inspired from openshift/installer https://github.com/openshift/installer/blob/master/pkg/asset/password/password.go
+func GenerateRandomPasswordHash() string {
+	password := StringWithCharset(23, alphanumericCharset)
+	pw := []rune(password)
+	for _, replace := range []int{5, 11, 17} {
+		pw[replace] = '-'
+	}
+
+	return string(pw)
+}