test(routing): add missing tests cases

Author: tkan145

spec/policy/routing/routing_operation_spec.lua

@@ -31,6 +31,46 @@ describe('RoutingOperation', function()
 
         assert.is_false(operation:evaluate(context))
       end)
+
+      it('evaluates != correctly when paths differ', function()
+        local operation = RoutingOperation.new_op_with_path('!=', '/expected')
+
+        local context = {
+          request = { get_uri = function() return '/other' end }
+        }
+
+        assert.is_true(operation:evaluate(context))
+      end)
+
+      it('evaluates != correctly when paths match', function()
+        local operation = RoutingOperation.new_op_with_path('!=', '/same')
+
+        local context = {
+          request = { get_uri = function() return '/same' end }
+        }
+
+        assert.is_false(operation:evaluate(context))
+      end)
+
+      it('evaluates matches true when regex matches', function()
+        local operation = RoutingOperation.new_op_with_path('matches', '^/api/.*')
+
+        local context = {
+          request = { get_uri = function() return '/api/users' end }
+        }
+
+        assert.is_true(operation:evaluate(context))
+      end)
+
+      it('evaluates matches false when regex does not match', function()
+        local operation = RoutingOperation.new_op_with_path('matches', '^/api/.*')
+
+        local context = {
+          request = { get_uri = function() return '/other/path' end }
+        }
+
+        assert.is_false(operation:evaluate(context))
+      end)
     end)
 
     describe('when the operation involves a header', function()
@@ -236,6 +276,12 @@ describe('RoutingOperation', function()
 
     end)
 
+    it('raises an error for unsupported operators', function()
+      assert.has_error(function()
+        RoutingOperation.new_op_with_path('unsupported_op', '/path')
+      end)
+    end)
+
     it('can evaluate the right operand as liquid', function()
       -- Stub the available context to avoid depending on ngx.var.*
       stub(ngx_variable, 'available_context', function(context) return context end)

spec/policy/routing/routing_spec.lua

@@ -2,8 +2,67 @@ local RoutingPolicy = require('apicast.policy.routing')
 local UpstreamSelector = require('apicast.policy.routing.upstream_selector')
 local Request = require('apicast.policy.routing.request')
 local Upstream = require('apicast.upstream')
+local mapping_rules_matcher = require('apicast.mapping_rules_matcher')
 
 describe('Routing policy', function()
+  describe('.access', function()
+    it('assigns route_upstream_usage_cleanup to the context', function()
+      local routing = RoutingPolicy.new()
+      local context = {}
+      routing:access(context)
+
+      assert.is_function(context.route_upstream_usage_cleanup)
+    end)
+
+    it('assigns the same function reference on every call', function()
+      local routing = RoutingPolicy.new()
+      local ctx1 = {}
+      local ctx2 = {}
+      routing:access(ctx1)
+      routing:access(ctx2)
+
+      assert.equals(ctx1.route_upstream_usage_cleanup, ctx2.route_upstream_usage_cleanup)
+    end)
+  end)
+
+  describe('route_upstream_usage_cleanup', function()
+    it('is a no-op when route_upstream is nil', function()
+      local routing = RoutingPolicy.new()
+      local context = {}
+      routing:access(context)
+
+      assert.has_no_errors(function()
+        context:route_upstream_usage_cleanup({}, {})
+      end)
+    end)
+
+    it('calls clean_usage_by_owner_id and merges usage when route_upstream exists', function()
+      local routing = RoutingPolicy.new()
+      local context = {}
+      routing:access(context)
+
+      local mock_owner_id = 42
+      context.route_upstream = {
+        has_owner_id = function() return mock_owner_id end,
+      }
+
+      local usage_diff = { some_metric = 1 }
+      stub(mapping_rules_matcher, 'clean_usage_by_owner_id').returns(usage_diff)
+
+      local usage = { merge = function() end }
+      stub(usage, 'merge')
+
+      local matched_rules = { 'rule1', 'rule2' }
+
+      context:route_upstream_usage_cleanup(usage, matched_rules)
+
+      assert.stub(mapping_rules_matcher.clean_usage_by_owner_id).was_called_with(
+        matched_rules, mock_owner_id
+      )
+      assert.stub(usage.merge).was_called_with(usage, usage_diff)
+    end)
+  end)
+
   describe('.content', function()
     describe('when there is an upstream that matches', function()
       local upstream_that_matches = Upstream.new('http://localhost')