Remove attr_protected from multiple models:

- Switches
- SystemName
- Finance::BillingStrategy
- Alert
- Forum
- Invitation
- MessageRecipient
- Metric
- Moderatorship
- PaymentDetail
- PaymentTransaction
- PlanMetric
- Profile
- Topic
- TopicCategory
- UserTopic

Author: mayorova

app/lib/switches.rb

@@ -164,7 +164,6 @@ def assign_switches(*switch_names)
   included do
     SWITCHES.each do |name|
       attr_name = "#{name}_switch"
-      attr_protected attr_name
 
       # Switches State Machine
       #

app/lib/system_name.rb

@@ -20,7 +20,6 @@ def validates_system_name(opts = {})
     end
 
     def has_system_name(opts = {})
-      attr_protected :system_name if opts.delete(:protected)
       self._system_human_name = opts.delete(:human_name) || :name
       validates_system_name(opts)
     end

app/models/alert.rb

@@ -15,8 +15,6 @@ class Alert < ApplicationRecord
 
   has_one :user_account, through: :cinstance
 
-  attr_protected :account_id, :cinstance_id, :tenant_id
-
   validates :account, :timestamp, :state, presence: true
   validates :utilization, :level, :alert_id, :cinstance, presence: true
   validates :alert_id, uniqueness: { scope: :account_id, case_sensitive: true }

app/models/finance/billing_strategy.rb

@@ -20,8 +20,6 @@ class << self
   belongs_to :account
   alias_method :provider, :account
 
-  attr_protected :account_id, :tenant_id, :audit_ids
-
   accepts_nested_attributes_for :account
   validates :currency, inclusion: { in: CURRENCIES.values, message: :invalid }
 

app/models/forum.rb

@@ -27,8 +27,6 @@ class Forum < ApplicationRecord
 
   scope :ordered, -> { order('position') }
 
-  attr_protected :topics_count, :posts_count, :account_id, :tenant_id
-
   def latest_posts
     posts.joins(:topic).order('posts.created_at DESC')
   end

app/models/invitation.rb

@@ -18,8 +18,6 @@ class Invitation < ApplicationRecord
   # so after first call it sets the sent_at attribute and breaks the infinite loop
   after_commit :notify_invitee, :on => :create, :unless => :sent?
 
-  attr_protected :accepted_at, :tenant_id
-
   default_scope -> { ordering { System::Database.oracle? ? sent_at.desc.op('', sql('NULLS LAST')) : sent_at.desc } }
 
   scope :pending, -> { where(accepted_at: nil) }

app/models/message_recipient.rb

@@ -29,8 +29,6 @@ class MessageRecipient < ApplicationRecord
   validates :message_id, :kind, :receiver_id, :receiver_type, presence: true
   validates :receiver_type, :kind, :state, length: { maximum: 255 }
 
-  attr_protected :message_id, :receiver_id, :receiver_type, :tenant_id
-
   # Make this class look like the actual message
   delegate  :sender, :subject, :body, :recipients, :to, :cc, :bcc, :created_at, :sender_name,
             :to => :message

app/models/metric.rb

@@ -26,7 +26,6 @@ class Metric < ApplicationRecord
 
   acts_as_tree
 
-  attr_protected :service_id, :parent_id, :tenant_id, :audit_ids
   validates :unit, presence: true, unless: :child?
   validates :friendly_name, uniqueness: { scope: %i[owner_type owner_id], case_sensitive: true }, presence: true
   validates :system_name, :unit, :friendly_name, :owner_type, length: { maximum: 255 }

app/models/moderatorship.rb

@@ -4,8 +4,6 @@ class Moderatorship < ApplicationRecord
   validates :user_id, :forum_id, presence: true
   validate :uniqueness_of_relationship
 
-  attr_protected :forum_id, :user_id, :tenant_id
-
   protected
 
   def uniqueness_of_relationship

app/models/payment_detail.rb

@@ -12,8 +12,6 @@ class PaymentDetail < ApplicationRecord
 
   audited allow_mass_assignment: true
 
-  attr_protected :account_id, :audit_ids
-
   validates :credit_card_partial_number, length: { :maximum => 4,
                                                    :allow_blank => true,
                                                    :message => "must be the final 4 digits only" }