Fix: private method 'warn' called for class ActiveSupport::Deprecation

Author: mayorova

features/step_definitions/custom_web_steps.rb

@@ -2,14 +2,14 @@
 
 #DEPRECATED: replace with <<there should( not| n't)? be a link to ([^"]*)>>
 Then "(I )(they )should see (a )(the )link to {}" do |page_name|
-  ActiveSupport::Deprecation.warn 'replace with <<there should( not| n\'t)? be a link to ([^"]*)>>'
+  ActiveSupport.deprecator.warn 'replace with <<there should( not| n\'t)? be a link to ([^"]*)>>'
   path = path_to(page_name)
   assert page.all('a').any? { |node| matches_path?(node[:href], path) }
 end
 
 #DEPRECATED: replace with <<there should( not| n't)? be a link to ([^"]*)>>
 Then /^I should not see link to (.+)$/ do |page_name|
-  ActiveSupport::Deprecation.warn 'replace with <<there should( not| n\'t)? be a link to ([^"]*)>>'
+  ActiveSupport.deprecator.warn 'replace with <<there should( not| n\'t)? be a link to ([^"]*)>>'
   path = path_to(page_name)
   assert page.all('a').none? { |node| matches_path?(node[:href], path) }
 end
@@ -21,7 +21,7 @@ def matches_path?(url, path)
 
 #DEPRECATED: replace with <<there should( not| n't)? be a link to ([^"]*)>>
 Then /^I should see (?:|the )link "([^"]*)" containing "([^"]*)" in the URL$/ do |label, params|
-  ActiveSupport::Deprecation.warn 'replace with <<there should( not| n\'t)? be a link to ([^"]*)>>'
+  ActiveSupport.deprecator.warn 'replace with <<there should( not| n\'t)? be a link to ([^"]*)>>'
   params = params.split
   href_contain_params = proc do |selector|
     params.each do |param|
@@ -33,13 +33,13 @@ def matches_path?(url, path)
 
 #DEPRECATED: replace with "there {should} be a link to {string}"
 Then /^(?:I )?should see (the |)link "([^"]*)"$/ do |_, label|
-  ActiveSupport::Deprecation.warn 'replace with "there {should} be a link to {string}"'
+  ActiveSupport.deprecator.warn 'replace with "there {should} be a link to {string}"'
   assert page.has_css?('a', :text => label)
 end
 
 #DEPRECATED: replace with "there {should} be a link to {string}"
 Then /^I should not see (?:the )?link "([^"]*)"$/ do |label|
-  ActiveSupport::Deprecation.warn 'replace with "there {should} be a link to {string}"'
+  ActiveSupport.deprecator.warn 'replace with "there {should} be a link to {string}"'
   assert page.has_no_xpath? ".//a[text()='#{label}']"
 end
 

features/step_definitions/finance/invoicing_steps.rb

@@ -54,7 +54,7 @@
 end
 
 Given "an invoice of {buyer} for {date} with items(:)" do |buyer, month, items|
-  ActiveSupport::Deprecation.warn '[Cucumber] Deprecated! Use the newer step.'
+  ActiveSupport.deprecator.warn '[Cucumber] Deprecated! Use the newer step.'
   invoice = create_invoice buyer, month
   items.hashes.each { |item| invoice.line_items.create!(item) }
 end
@@ -109,7 +109,7 @@
 end
 
 Then /^the buyer should have following line items for "([^"]*)"(?: in the (\d)(?:nd|st|rd|th))? invoice:$/ do |date, order, items|
-  ActiveSupport::Deprecation.warn '[Cucumber] Deprecated! Assert table instead.'
+  ActiveSupport.deprecator.warn '[Cucumber] Deprecated! Assert table instead.'
   step "the buyer logs in"
 
   visit admin_account_invoices_path
@@ -133,7 +133,7 @@
 
 # TODO: change to accept REGEXPs! (use page.body and assert)
 Then(/^I should see line items$/) do |items|
-  ActiveSupport::Deprecation.warn '[Cucumber] Deprecated! Assert table instead.'
+  ActiveSupport.deprecator.warn '[Cucumber] Deprecated! Assert table instead.'
   assert_line_items(items)
 end
 

features/step_definitions/form_steps.rb

@@ -91,7 +91,7 @@
 end
 
 When "(I )(they )select {string} from {string}" do |value, field|
-  ActiveSupport::Deprecation.warn "[cucumber] Detected a form not using PF4 css" unless page.has_css?('.pf-c-form__label', text: field, wait: 0)
+  ActiveSupport.deprecator.warn "[cucumber] Detected a form not using PF4 css" unless page.has_css?('.pf-c-form__label', text: field, wait: 0)
   element = find_field(field)
   # 'input' for React forms, and 'select' for HTML
   if element.tag_name == 'select'

features/step_definitions/pagination_steps.rb

@@ -2,7 +2,7 @@
 
 Then "(I )(they )should see {int} pages" do |count|
   if has_css?('.pagination', wait: 0)
-    ActiveSupport::Deprecation.warn 'Implement table toolbar instead'
+    ActiveSupport.deprecator.warn 'Implement table toolbar instead'
     links = within(".pagination") do
       all("a:not(.next_page), em.current")
     end
@@ -17,7 +17,7 @@
 
 When "they look at the {ordinal} page" do |page|
   if has_css?('.pagination', wait: 0)
-    ActiveSupport::Deprecation.warn 'Implement table toolbar instead'
+    ActiveSupport.deprecator.warn 'Implement table toolbar instead'
     within ".pagination" do
       click_link page
     end

features/step_definitions/search_steps.rb

@@ -29,7 +29,7 @@
 
 # DEPRECATED: remove and use "the table is filtered with:"
 When "I/they search for:" do |table|
-  ActiveSupport::Deprecation.warn 'remove and use "the table is filtered with:"'
+  ActiveSupport.deprecator.warn 'remove and use "the table is filtered with:"'
   within ".search" do
     parameterize_headers(table)
 

features/step_definitions/service_steps.rb

@@ -47,12 +47,12 @@
 end
 
 Given "the service of {provider} has {string} {enabled}" do |account, toggle, enabled|
-  ActiveSupport::Deprecation.warn '[cucumber] stop using "the service of provider" use "product" instead'
+  ActiveSupport.deprecator.warn '[cucumber] stop using "the service of provider" use "product" instead'
   account.first_service!.update_attribute("#{underscore_spaces(toggle)}_enabled", enabled)
 end
 
 Given "the service of {provider} has {string} set to {string}" do |account, name, value|
-  ActiveSupport::Deprecation.warn '[cucumber] stop using "the service of provider" use "product" instead'
+  ActiveSupport.deprecator.warn '[cucumber] stop using "the service of provider" use "product" instead'
   account.first_service!.update_attribute(underscore_spaces(name), value)
 end
 

features/support/capybara_extensions.rb

@@ -19,7 +19,7 @@ def fill_in(field, with:, **options)
           .find('input.pf-c-form-control')
           .set with
     else
-      ActiveSupport::Deprecation.warn "[cucumber] field not implemented with Patternfly: #{field}"
+      ActiveSupport.deprecator.warn "[cucumber] field not implemented with Patternfly: #{field}"
       super
     end
   end
@@ -40,7 +40,7 @@ def select(value = nil, from: nil, **options)
         end
       end
     else
-      ActiveSupport::Deprecation.warn "[cucumber] Select not implemented with Patternfly: #{from}"
+      ActiveSupport.deprecator.warn "[cucumber] Select not implemented with Patternfly: #{from}"
       super
     end
   end

features/support/helpers/table_helpers.rb

@@ -12,7 +12,7 @@ module TableHelpers
   #
   def extract_table(table, rows, cells = nil)
     table = find(*table)
-    ActiveSupport::Deprecation.warn '[Cucumber] Table not implemented with Patternfly' unless table[:class].include?('pf-c-table')
+    ActiveSupport.deprecator.warn '[Cucumber] Table not implemented with Patternfly' unless table[:class].include?('pf-c-table')
     table.all(*rows).map do |row|
       if cells.respond_to?(:call)
         cells.call(row)

features/support/plan_helpers.rb

@@ -1,7 +1,7 @@
 module PlanHelpers
 
   def create_plan(type, options)
-    ActiveSupport::Deprecation.warn '[create_plan] Stop using this method, use factories'
+    ActiveSupport.deprecator.warn '[create_plan] Stop using this method, use factories'
     options[:cost] ||= 0
 
     issuer = options[:issuer]