Skip to content

Strong params together#4332

Closed
akostadinov wants to merge 44 commits into
masterfrom
strong_params
Closed

Strong params together#4332
akostadinov wants to merge 44 commits into
masterfrom
strong_params

Conversation

@akostadinov

Copy link
Copy Markdown
Contributor

merging #4248, #4249 and #4255

mayorova added 30 commits June 2, 2026 19:44
- AuthenticationProvider::RedhatCustomerPortal
- AuthenticationProvider::ServiceDiscoveryProvider
- CMS::GroupSection
- CMS::Permission
- ApplicationKey
- BackendEvent
- LineItem
- Onboarding
- Partner
- Post
- ReferrerFilter
- Switches
- SystemName
- Finance::BillingStrategy
- Alert
- Forum
- Invitation
- MessageRecipient
- Metric
- Moderatorship
- PaymentDetail
- PaymentTransaction
- PlanMetric
- Profile
- Topic
- TopicCategory
- UserTopic
@qltysh

qltysh Bot commented Jul 6, 2026

Copy link
Copy Markdown

❌ 31 blocking issues (31 total)

Tool Category Rule Count
reek Lint Provider::Admin::AccountsController#update_account_params has approx 9 statements 5
rubocop Lint Class has too many lines. [206/200] 5
rubocop Lint Assignment Branch Condition size for create is too high. [<4, 26, 3> 26.48/20] 4
rubocop Lint Prefer response\.parsed\_body. 4
reek Lint Admin::FieldsDefinitionsController#edit calls 'fields_definition.target_class' 2 times 2
reek Lint DeveloperPortal::BaseController#filter_readonly_params refers to 'read_only_fields' more than self (maybe move it to another class?) 2
reek Lint Admin::FieldsDefinitionsController#set_fields_definition_params manually dispatches method call 1
brakeman Vulnerability Specify exact keys allowed for mass assignment instead of using permit\! which allows any keys. 1
rubocop Style Incorrect formatting, autoformat by running qlty fmt. 1
rubocop Style Trailing whitespace detected. 1
rubocop Lint Use anonymous block forwarding. 1
rubocop Style Use anonymous block arguments forwarding (&). 1
rubocop Style 1 trailing blank lines detected. 1
rubocop Lint Use find\_by\! instead of dynamic find\_by\_code\!. 1
reek Lint ApplicationsControllerMethodsTest::TestController#params is a writable attribute 1

@qltysh one-click actions:

  • Auto-fix formatting (qlty fmt && git push)

jlledom
jlledom previously approved these changes Jul 6, 2026
@akostadinov

Copy link
Copy Markdown
Contributor Author

decided to merge the original PRs individually

@akostadinov akostadinov closed this Jul 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants