Merge pull request DSpace#12291 from 4Science/task/main/DURACOM-473

[DURACOM-473] Fix on vocabulary browse with anonymous

Author: tdonohue

dspace-api/src/main/java/org/dspace/content/authority/DCInputAuthority.java

@@ -217,6 +217,19 @@ public String getLabel(String key, String locale) {
         }
     }
 
+    /**
+     * Value-pairs from submission forms are always considered public.
+     * They contain static, non-sensitive dropdown options (e.g., document
+     * types, languages, OpenAIRE vocabularies) that must be browsable
+     * by anonymous users in submission vocabulary lookups.
+     *
+     * @return always {@code true}
+     */
+    @Override
+    public boolean isPublic() {
+        return true;
+    }
+
     @Override
     public boolean isScrollable() {
         return true;

dspace-api/src/main/java/org/dspace/content/authority/DSpaceControlledVocabulary.java

@@ -87,6 +87,19 @@ public DSpaceControlledVocabulary() {
         super();
     }
 
+    /**
+     * Controlled vocabulary XML files are always considered public.
+     * They contain static, non-sensitive classification data (e.g., subject
+     * taxonomies like SRSC or NSI) that must be browsable by anonymous users
+     * in submission vocabulary lookups.
+     *
+     * @return always {@code true}
+     */
+    @Override
+    public boolean isPublic() {
+        return true;
+    }
+
     @Override
     public boolean storeAuthorityInMetadata() {
         init(null);

dspace-server-webapp/src/test/java/org/dspace/app/rest/VocabularyRestRepositoryIT.java

@@ -213,6 +213,59 @@ public void correctSrscQueryTest() throws Exception {
                 .andExpect(jsonPath("$.page.size", Matchers.is(2)));
     }
 
+    /**
+     * Verifies that anonymous users can browse entries from a
+     * {@link org.dspace.content.authority.DSpaceControlledVocabulary}-backed
+     * vocabulary (XML hierarchical taxonomy like SRSC).
+     * These vocabularies are public and must not require authentication.
+     */
+    @Test
+    public void correctSrscQueryAnonymousUserTest() throws Exception {
+        getClient().perform(
+                            get("/api/submission/vocabularies/srsc/entries")
+                                .param("filter", "Research")
+                                .param("size", "2"))
+                        .andExpect(status().isOk())
+                        .andExpect(jsonPath("$._embedded.entries", Matchers.containsInAnyOrder(
+                            VocabularyMatcher.matchVocabularyEntry(
+                                "Research Subject Categories", "", "vocabularyEntry"),
+                            VocabularyMatcher.matchVocabularyEntry(
+                                "Family research",
+                                "SOCIAL SCIENCES::Social sciences::Social work"
+                                    + "::Family research",
+                                "vocabularyEntry"))))
+                        .andExpect(jsonPath("$.page.totalElements", Matchers.is(26)))
+                        .andExpect(jsonPath("$.page.totalPages", Matchers.is(13)))
+                        .andExpect(jsonPath("$.page.size", Matchers.is(2)));
+    }
+
+    /**
+     * Verifies that anonymous users can browse entries from a
+     * {@link DCInputAuthority}-backed vocabulary (value-pairs).
+     * These vocabularies are public and must not require authentication.
+     */
+    @Test
+    public void correctCommonTypesQueryAnonymousUserTest() throws Exception {
+        getClient().perform(
+                        get("/api/submission/vocabularies/common_types/entries")
+                            .param("filter", "Book")
+                            .param("size", "2"))
+                        .andExpect(status().isOk())
+                        .andExpect(jsonPath("$._embedded.entries",
+                            Matchers.containsInAnyOrder(
+                                VocabularyMatcher.matchVocabularyEntry(
+                                    "Book", "Book", "vocabularyEntry"),
+                                VocabularyMatcher.matchVocabularyEntry(
+                                    "Book chapter", "Book chapter",
+                                    "vocabularyEntry"))))
+                        .andExpect(jsonPath("$.page.totalElements",
+                            Matchers.is(2)))
+                        .andExpect(jsonPath("$.page.totalPages",
+                            Matchers.is(1)))
+                        .andExpect(jsonPath("$.page.size",
+                            Matchers.is(2)));
+    }
+
     @Test
     public void notScrollableVocabularyRequiredQueryTest() throws Exception {
         String token = getAuthToken(admin.getEmail(), password);