[DURACOM-456] clean up unused property, add guard if selected file is missing, add form value interface

Author: FrancescoMolinaro

src/app/bulk-import/bulk-import-page.component.html

@@ -14,16 +14,10 @@ <h2 class="mb-3">{{ 'bulk-import.title' | translate }}</h2>
       <label for="abortOnError" class="me-5">{{ 'bulk-import.abort-on-error' | translate }}</label>
     </div>
 
-    <button type="submit" class="btn btn-primary float-end" [dsBtnDisabled]="form.invalid || (isProcessingImport() | async)" >
-      @if ((isProcessingImport() | async)) {
-        <span>
-          <i class='fas fa-circle-notch fa-spin'></i> {{'bulk-import.processing' | translate}}
-        </span>
-      } @else {
+    <button type="submit" class="btn btn-primary float-end" [dsBtnDisabled]="form.invalid" >
         <span>
           {{'bulk-import.submit' | translate}}
         </span>
-      }
     </button>
     <button type="button" class="btn btn-outline-secondary float-end me-2" (click)="goBack()">
       {{'bulk-import.back' | translate}}

src/app/bulk-import/bulk-import-page.component.ts

@@ -22,11 +22,7 @@ import {
   TranslateModule,
   TranslateService,
 } from '@ngx-translate/core';
-import {
-  BehaviorSubject,
-  Observable,
-  Subscription,
-} from 'rxjs';
+import { Subscription } from 'rxjs';
 import {
   map,
   take,
@@ -43,6 +39,15 @@ import { Collection } from '../core/shared/collection.model';
 import { getFirstCompletedRemoteData } from '../core/shared/operators';
 import { FileValidator } from '../shared/utils/require-file.validator';
 
+/**
+ * Form values for bulk import page
+ */
+interface BulkImportFormValues {
+  name: string;
+  file?: File;
+  abortOnError: boolean;
+}
+
 /**
  * Page to perform an items bulk imports into the given collection.
  */
@@ -65,12 +70,6 @@ export class BulkImportPageComponent implements OnInit, OnDestroy {
 
   subs: Subscription[] = [];
 
-  /**
-   * A boolean representing if a create delete operation is pending
-   * @type {BehaviorSubject<boolean>}
-   */
-  processingImport$: BehaviorSubject<boolean>  = new BehaviorSubject<boolean>(false);
-
   private selectedFile: File;
 
   constructor(
@@ -113,8 +112,12 @@ export class BulkImportPageComponent implements OnInit, OnDestroy {
    * @param form
    */
   submit() {
+    if (!this.selectedFile) {
+      this.notificationsService.error(this.translationService.get('bulk-import.error.no-file'));
+      return;
+    }
 
-    const values: any = this.form.value;
+    const values: BulkImportFormValues = this.form.value;
 
     const stringParameters: ProcessParameter[] = [
       { name: '-c', value: this.collectionId },
@@ -141,14 +144,6 @@ export class BulkImportPageComponent implements OnInit, OnDestroy {
     this.router.navigateByUrl(getCollectionPageRoute(this.collectionId));
   }
 
-  /**
-   * Return a boolean representing if t import operation is pending.
-   *
-   * @return {Observable<boolean>}
-   */
-  isProcessingImport(): Observable<boolean> {
-    return this.processingImport$.asObservable();
-  }
 
   private navigateToProcesses() {
     this.requestService.setStaleByHrefSubstring('/processes');

src/assets/i18n/en.json5

@@ -1213,6 +1213,8 @@
 
   "bulk-import.error": "An error occurred while creating the import process",
 
+  "bulk-import.error.no-file": "Please select a file to import.",
+
   "bulk-import.file": "Source file",
 
   "bulk-import.header": "Bulk import",