Do not show footer option in CMS if topFooter is not enabled

Author: Maciej Kleban

config/config.example.yml

@@ -387,6 +387,8 @@ communityList:
   pageSize: 20
 
 homePage:
+  # Whether to show the top footer section or not
+  showTopFooter: false
   recentSubmissions:
     # The number of item showing in recent submission components
     pageSize: 5

src/app/admin/admin-edit-cms-metadata/admin-edit-cms-metadata.component.spec.ts

@@ -84,7 +84,8 @@ describe('AdminEditCmsMetadataComponent', () => {
     });
 
     it('should show metadata cms list correctly', () => {
-      const metadataListLength = environment.cms.metadataList.length;
+      // Substract 1 because the top footer is not included in the list if it is not enabled (and it's not, by default)
+      const metadataListLength = environment.cms.metadataList.length - 1;
       const selectMetadata = fixture.debugElement.query(By.css('select'));
       expect(selectMetadata.children).toHaveSize(metadataListLength + 1);
     });

src/app/admin/admin-edit-cms-metadata/admin-edit-cms-metadata.component.ts

@@ -78,6 +78,10 @@ export class AdminEditCmsMetadataComponent implements OnInit {
       this.languageMap.set(language.code, language.label);
     });
     environment.cms.metadataList.forEach((md) => {
+      // Do not allow the user to edit the top footer if it is not enabled
+      if (md === 'dspace.cms.footer' && !environment.homePage.showTopFooter) {
+        return;
+      }
       this.metadataList.push(md);
     });
     this.siteService.find().subscribe((site) => {