Merge pull request DSpace#5089 from guillermo-escire/feature/3949

Remove console.log and enforce ESLint no-console rule (DSpace#3949)

Author: tdonohue

.eslintrc.json

@@ -70,7 +70,6 @@
           "error",
           {
             "allow": [
-              "log",
               "warn",
               "dir",
               "timeLog",

cypress/plugins/index.ts

@@ -13,7 +13,7 @@ module.exports = (on, config) => {
     // Define "log" and "table" tasks, used for logging accessibility errors during CI
     // Borrowed from https://github.com/component-driven/cypress-axe#in-cypress-plugins-file
     log(message: string) {
-      console.log(message);
+      console.info(message);
       return null;
     },
     table(message: string) {

src/app/admin/admin-edit-cms-metadata/admin-edit-cms-metadata.component.spec.ts

@@ -117,7 +117,6 @@ describe('AdminEditCmsMetadataComponent', () => {
     it('should render textareas of the languages', () => {
       const languagesLength = environment.languages.filter((l) => l.active).length;
       const textareas = fixture.debugElement.queryAll(By.css('textarea'));
-      console.log(textareas.length, languagesLength);
       expect(textareas).toHaveSize(languagesLength);
     });
 

src/app/app.metareducers.ts

@@ -6,10 +6,10 @@ let actionCounter = 0;
 export function debugMetaReducer(reducer) {
   return (state, action) => {
     actionCounter++;
-    console.log('@ngrx action', actionCounter, action.type);
-    console.log('state', JSON.stringify(state));
-    console.log('action', JSON.stringify(action));
-    console.log('------------------------------------');
+    console.debug('@ngrx action', actionCounter, action.type);
+    console.debug('state', JSON.stringify(state));
+    console.debug('action', JSON.stringify(action));
+    console.debug('------------------------------------');
     return reducer(state, action);
   };
 }

src/app/core/data/debug-response-parsing.service.ts

@@ -8,7 +8,6 @@ import { RestRequest } from './rest-request.model';
 @Injectable({ providedIn: 'root' })
 export class DebugResponseParsingService implements ResponseParsingService {
   parse(request: RestRequest, data: RawRestResponse): RestResponse {
-    console.log('request', request, 'data', data);
     return undefined;
   }
 }

src/app/core/dspace-rest/dspace-rest.service.spec.ts

@@ -86,10 +86,10 @@ describe('DspaceRestService', () => {
     });
 
     it('should log an error', () => {
-      spyOn(console, 'log');
+      spyOn(console, 'error');
 
       dspaceRestService.get(url).subscribe(() => undefined, (err: unknown) => {
-        expect(console.log).toHaveBeenCalled();
+        expect(console.error).toHaveBeenCalled();
       });
 
       const req = httpMock.expectOne(url);

src/app/core/dspace-rest/dspace-rest.service.ts

@@ -65,7 +65,7 @@ export class DspaceRestService {
         statusText: res.statusText,
       })),
       catchError((err: unknown) => observableThrowError(() => {
-        console.log('Error: ', err);
+        console.error('Error: ', err);
         return this.handleHttpError(err);
       })),
     );

src/app/core/testing/auth-service.stub.ts

@@ -39,7 +39,6 @@ export class AuthServiceStub {
       authStatus.eperson = createSuccessfulRemoteDataObject$(EPersonMock);
       return of(authStatus);
     } else {
-      console.log('error');
       throw (new Error('Message Error test'));
     }
   }

src/app/notifications/suggestions/sources/suggestion-sources.component.spec.ts

@@ -83,7 +83,6 @@ describe('SuggestionSourcesComponent', () => {
   beforeEach(waitForAsync(() => {
     // Mock the suggestion source data service to return an empty list
     mockSuggestionSourceDataService.getSources.and.returnValue(mockPaginatedListRD);
-    console.log(mockSuggestionSourceDataService);
     fixture = TestBed.createComponent(SuggestionSourcesComponent);
     component = fixture.componentInstance;
     fixture.detectChanges();

src/app/notifications/suggestions/sources/suggestion-sources.component.ts

@@ -21,7 +21,6 @@ import {
   distinctUntilChanged,
   map,
   switchMap,
-  tap,
 } from 'rxjs/operators';
 
 import { AlertComponent } from '../../../shared/alert/alert.component';
@@ -80,7 +79,6 @@ export class SuggestionSourcesComponent {
       }),
       takeUntilDestroyed(),
     ).subscribe((results: Partial<PaginatedList<SuggestionSource>>) =>  {
-      console.log(results);
       this.sources$.next(results.page);
       this.totalElements$.next(results.pageInfo?.totalElements ?? 0);
       this.loading$.next(false);
@@ -104,7 +102,6 @@ export class SuggestionSourcesComponent {
 
     return this.suggestionSourceDataService.getSources(options).pipe(
       getFirstCompletedRemoteData(),
-      tap(console.log),
       map((result: RemoteData<PaginatedList<SuggestionSource>>) => {
         return result.hasSucceeded ? result.payload : { page: [], pageInfo: null };
       }),