[DURACOM-383] update tests

Author: Micheleboychuk

src/app/collection-page/delete-collection-page/delete-collection-page.component.spec.ts

@@ -5,31 +5,61 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
-import { ActivatedRoute } from '@angular/router';
+import {
+  ActivatedRoute,
+  Router,
+} from '@angular/router';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
 import { CollectionDataService } from '../../core/data/collection-data.service';
-import { RequestService } from '../../core/data/request.service';
+import {
+  DSPACE_OBJECT_DELETION_SCRIPT_NAME,
+  ScriptDataService,
+} from '../../core/data/processes/script-data.service';
+import { Collection } from '../../core/shared/collection.model';
+import { getProcessDetailRoute } from '../../process-page/process-page-routing.paths';
+import { ProcessParameter } from '../../process-page/processes/process-parameter.model';
 import { DSONameServiceMock } from '../../shared/mocks/dso-name.service.mock';
 import { NotificationsService } from '../../shared/notifications/notifications.service';
+import {
+  createFailedRemoteDataObject$,
+  createSuccessfulRemoteDataObject$,
+} from '../../shared/remote-data.utils';
+import { NotificationsServiceStub } from '../../shared/testing/notifications-service.stub';
 import { DeleteCollectionPageComponent } from './delete-collection-page.component';
 
 describe('DeleteCollectionPageComponent', () => {
   let comp: DeleteCollectionPageComponent;
   let fixture: ComponentFixture<DeleteCollectionPageComponent>;
+  let scriptService;
+  let notificationService: NotificationsServiceStub;
+  let router;
+
+  const mockCollection: Collection = Object.assign(new Collection(), {
+    uuid: 'test-uuid',
+    id: 'test-uuid',
+    name: 'Test Collection',
+    type: 'collection',
+  });
 
   beforeEach(waitForAsync(() => {
+    notificationService = new NotificationsServiceStub();
+    scriptService = jasmine.createSpyObj('scriptService', {
+      invoke: createSuccessfulRemoteDataObject$({ processId: '123' }),
+    });
+    router = jasmine.createSpyObj('router', ['navigateByUrl']);
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot(), CommonModule, RouterTestingModule, DeleteCollectionPageComponent],
       providers: [
         { provide: DSONameService, useValue: new DSONameServiceMock() },
         { provide: CollectionDataService, useValue: {} },
-        { provide: ActivatedRoute, useValue: { data: of({ dso: { payload: {} } }) } },
-        { provide: NotificationsService, useValue: {} },
-        { provide: RequestService, useValue: {} },
+        { provide: ActivatedRoute, useValue: { data: of({ dso: { payload: mockCollection } }) } },
+        { provide: NotificationsService, useValue: notificationService },
+        { provide: ScriptDataService, useValue: scriptService },
+        { provide: Router, useValue: router },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     }).compileComponents();
@@ -41,9 +71,28 @@ describe('DeleteCollectionPageComponent', () => {
     fixture.detectChanges();
   });
 
-  describe('frontendURL', () => {
-    it('should have the right frontendURL set', () => {
-      expect((comp as any).frontendURL).toEqual('/collections/');
+  it('should create', () => {
+    expect(comp).toBeTruthy();
+  });
+
+  it('should have the right frontendURL set', () => {
+    expect((comp as any).frontendURL).toEqual('/collections/');
+  });
+
+  describe('onConfirm', () => {
+    it('should invoke the deletion script with correct params, show success notification and redirect on success', (done) => {
+      const parameterValues: ProcessParameter[] = [
+        Object.assign(new ProcessParameter(), { name: '-i', value: mockCollection.uuid }),
+      ];
+      (scriptService.invoke as jasmine.Spy).and.returnValue(createSuccessfulRemoteDataObject$({ processId: '123' }));
+      expect(scriptService.invoke).toHaveBeenCalledWith(DSPACE_OBJECT_DELETION_SCRIPT_NAME, parameterValues, []);
+      expect(notificationService.success).toHaveBeenCalledWith('collection.delete.notification.success');
+      expect(router.navigateByUrl).toHaveBeenCalledWith(getProcessDetailRoute('123'));
+    });
+
+    it('error notification is shown', (done) => {
+      (scriptService.invoke as jasmine.Spy).and.returnValue(createFailedRemoteDataObject$('Error', 500));
+      expect(notificationService.error).toHaveBeenCalledWith('collection.delete.notification.fail');
     });
   });
 });

src/app/community-page/delete-community-page/delete-community-page.component.spec.ts

@@ -5,31 +5,61 @@ import {
   TestBed,
   waitForAsync,
 } from '@angular/core/testing';
-import { ActivatedRoute } from '@angular/router';
+import {
+  ActivatedRoute,
+  Router,
+} from '@angular/router';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
 import { of } from 'rxjs';
 
 import { DSONameService } from '../../core/breadcrumbs/dso-name.service';
 import { CommunityDataService } from '../../core/data/community-data.service';
-import { RequestService } from '../../core/data/request.service';
+import {
+  DSPACE_OBJECT_DELETION_SCRIPT_NAME,
+  ScriptDataService,
+} from '../../core/data/processes/script-data.service';
+import { Community } from '../../core/shared/community.model';
+import { getProcessDetailRoute } from '../../process-page/process-page-routing.paths';
+import { ProcessParameter } from '../../process-page/processes/process-parameter.model';
 import { DSONameServiceMock } from '../../shared/mocks/dso-name.service.mock';
 import { NotificationsService } from '../../shared/notifications/notifications.service';
+import {
+  createFailedRemoteDataObject$,
+  createSuccessfulRemoteDataObject$,
+} from '../../shared/remote-data.utils';
+import { NotificationsServiceStub } from '../../shared/testing/notifications-service.stub';
 import { DeleteCommunityPageComponent } from './delete-community-page.component';
 
 describe('DeleteCommunityPageComponent', () => {
   let comp: DeleteCommunityPageComponent;
   let fixture: ComponentFixture<DeleteCommunityPageComponent>;
+  let scriptService;
+  let notificationService: NotificationsServiceStub;
+  let router;
+
+  const mockCommunity: Community = Object.assign(new Community(), {
+    uuid: 'test-uuid',
+    id: 'test-uuid',
+    name: 'Test Community',
+    type: 'community',
+  });
 
   beforeEach(waitForAsync(() => {
+    notificationService = new NotificationsServiceStub();
+    scriptService = jasmine.createSpyObj('scriptService', {
+      invoke: createSuccessfulRemoteDataObject$({ processId: '123' }),
+    });
+    router = jasmine.createSpyObj('router', ['navigateByUrl']);
     TestBed.configureTestingModule({
       imports: [TranslateModule.forRoot(), CommonModule, RouterTestingModule, DeleteCommunityPageComponent],
       providers: [
         { provide: DSONameService, useValue: new DSONameServiceMock() },
         { provide: CommunityDataService, useValue: {} },
-        { provide: ActivatedRoute, useValue: { data: of({ dso: { payload: {} } }) } },
-        { provide: NotificationsService, useValue: {} },
-        { provide: RequestService, useValue: {} },
+        { provide: ActivatedRoute, useValue: { data: of({ dso: { payload: mockCommunity } }) } },
+        { provide: NotificationsService, useValue: notificationService },
+        { provide: ScriptDataService, useValue: scriptService },
+        { provide: Router, useValue: router },
       ],
       schemas: [NO_ERRORS_SCHEMA],
     }).compileComponents();
@@ -41,9 +71,29 @@ describe('DeleteCommunityPageComponent', () => {
     fixture.detectChanges();
   });
 
-  describe('frontendURL', () => {
-    it('should have the right frontendURL set', () => {
-      expect((comp as any).frontendURL).toEqual('/communities/');
+  it('should create', () => {
+    expect(comp).toBeTruthy();
+  });
+
+  it('should have the right frontendURL set', () => {
+    expect((comp as any).frontendURL).toEqual('/communities/');
+  });
+
+  describe('onConfirm', () => {
+    it('should invoke the deletion script with correct params, show success notification and redirect on success', (done) => {
+      const parameterValues: ProcessParameter[] = [
+        Object.assign(new ProcessParameter(), { name: '-i', value: mockCommunity.uuid }),
+      ];
+      (scriptService.invoke as jasmine.Spy).and.returnValue(createSuccessfulRemoteDataObject$({ processId: '123' }));
+      expect(scriptService.invoke).toHaveBeenCalledWith(DSPACE_OBJECT_DELETION_SCRIPT_NAME, parameterValues, []);
+      expect(notificationService.success).toHaveBeenCalledWith('community.delete.notification.success');
+      expect(router.navigateByUrl).toHaveBeenCalledWith(getProcessDetailRoute('123'));
+    });
+
+    it('error notification is shown', (done) => {
+      (scriptService.invoke as jasmine.Spy).and.returnValue(createFailedRemoteDataObject$('Error', 500));
+      expect(notificationService.error).toHaveBeenCalledWith('community.delete.notification.fail');
     });
   });
+
 });

src/app/item-page/edit-item-page/item-delete/item-delete.component.ts

@@ -178,7 +178,7 @@ export class ItemDeleteComponent
               protected relationshipService: RelationshipDataService,
               protected entityTypeService: EntityTypeDataService,
               protected linkService: LinkService,
-              protected scriptDataService: ScriptDataService, // AGGIUNTO
+              protected scriptDataService: ScriptDataService,
   ) {
     super(
       route,