Merge pull request DSpace#5483 from guillermo-escire/feature/5435

Fix DSpace#5435: show permission denied message when 403 on collection mapper

Author: tdonohue

src/app/item-page/edit-item-page/item-collection-mapper/item-collection-mapper.component.spec.ts

@@ -180,6 +180,13 @@ describe('ItemCollectionMapperComponent', () => {
       expect(notificationsService.success).not.toHaveBeenCalled();
       expect(notificationsService.error).toHaveBeenCalled();
     });
+
+    it('should display a permission error message if mapping returns 403', () => {
+      spyOn(itemDataService, 'mapToCollection').and.returnValue(createFailedRemoteDataObject$('Forbidden', 403));
+      comp.mapCollections(ids);
+      expect(notificationsService.success).not.toHaveBeenCalled();
+      expect(notificationsService.error).toHaveBeenCalled();
+    });
   });
 
   describe('removeMappings', () => {
@@ -197,6 +204,13 @@ describe('ItemCollectionMapperComponent', () => {
       expect(notificationsService.success).not.toHaveBeenCalled();
       expect(notificationsService.error).toHaveBeenCalled();
     });
+
+    it('should display a permission error message if removal returns 403', () => {
+      spyOn(itemDataService, 'removeMappingFromCollection').and.returnValue(createFailedRemoteDataObject$('Forbidden', 403));
+      comp.removeMappings(ids);
+      expect(notificationsService.success).not.toHaveBeenCalled();
+      expect(notificationsService.error).toHaveBeenCalled();
+    });
   });
 
   describe('tabChange', () => {

src/app/item-page/edit-item-page/item-collection-mapper/item-collection-mapper.component.ts

@@ -287,14 +287,28 @@ export class ItemCollectionMapperComponent implements OnInit {
         this.shouldUpdate$.next(true);
       }
       if (unsuccessful.length > 0) {
-        const unsuccessMessages = observableCombineLatest([
-          this.translateService.get(`${messagePrefix}.error.head`),
-          this.translateService.get(`${messagePrefix}.error.content`, { amount: unsuccessful.length }),
-        ]);
+        const forbidden = unsuccessful.filter((response: RemoteData<NoContent>) => response.statusCode === 403);
+        const otherErrors = unsuccessful.filter((response: RemoteData<NoContent>) => response.statusCode !== 403);
 
-        unsuccessMessages.subscribe(([head, content]) => {
-          this.notificationsService.error(head, content);
-        });
+        if (forbidden.length > 0) {
+          const forbiddenMessages = observableCombineLatest([
+            this.translateService.get(`${messagePrefix}.error.forbidden.head`),
+            this.translateService.get(`${messagePrefix}.error.forbidden.content`),
+          ]);
+          forbiddenMessages.subscribe(([head, content]) => {
+            this.notificationsService.error(head, content);
+          });
+        }
+
+        if (otherErrors.length > 0) {
+          const unsuccessMessages = observableCombineLatest([
+            this.translateService.get(`${messagePrefix}.error.head`),
+            this.translateService.get(`${messagePrefix}.error.content`, { amount: otherErrors.length }),
+          ]);
+          unsuccessMessages.subscribe(([head, content]) => {
+            this.notificationsService.error(head, content);
+          });
+        }
       }
       this.switchToFirstTab();
     });

src/assets/i18n/en.json5

@@ -2643,6 +2643,10 @@
 
   "item.edit.item-mapper.notifications.add.error.content": "Errors occurred for mapping of item to {{amount}} collections.",
 
+  "item.edit.item-mapper.notifications.add.error.forbidden.head": "Permission denied",
+
+  "item.edit.item-mapper.notifications.add.error.forbidden.content": "You do not have permission to map this item to a collection.",
+
   "item.edit.item-mapper.notifications.add.error.head": "Mapping errors",
 
   "item.edit.item-mapper.notifications.add.success.content": "Successfully mapped item to {{amount}} collections.",
@@ -2651,6 +2655,10 @@
 
   "item.edit.item-mapper.notifications.remove.error.content": "Errors occurred for the removal of the mapping to {{amount}} collections.",
 
+  "item.edit.item-mapper.notifications.remove.error.forbidden.head": "Permission denied",
+
+  "item.edit.item-mapper.notifications.remove.error.forbidden.content": "You do not have permission to remove this item from a collection.",
+
   "item.edit.item-mapper.notifications.remove.error.head": "Removal of mapping errors",
 
   "item.edit.item-mapper.notifications.remove.success.content": "Successfully removed mapping of item to {{amount}} collections.",