Skip to content

Commit 346bdb8

Browse files
authored
Merge pull request DSpace#4446 from alexandrevryghem/w2p-132007_remove-theme-modules_contribute-main
Removed theme modules
2 parents aadea29 + 1b2541f commit 346bdb8

17 files changed

Lines changed: 112 additions & 461 deletions

src/app/app.config.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ import { ScrollToModule } from '@nicky-lenaers/ngx-scroll-to';
4646
import { provideEnvironmentNgxMask } from 'ngx-mask';
4747

4848
import { environment } from '../environments/environment';
49-
import { EagerThemesModule } from '../themes/eager-themes.module';
5049
import { appEffects } from './app.effects';
5150
import { MENUS } from './app.menus';
5251
import {
@@ -99,7 +98,6 @@ export const commonAppConfig: ApplicationConfig = {
9998
StoreModule.forRoot(appReducers, storeModuleConfig),
10099
StoreRouterConnectingModule.forRoot(),
101100
StoreDevModules,
102-
EagerThemesModule,
103101
RootModule,
104102
ListableModule.withEntryComponents(),
105103
),

src/app/root.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { CommonModule } from '@angular/common';
22
import { NgModule } from '@angular/core';
33
import { NgbModule } from '@ng-bootstrap/ng-bootstrap';
44

5+
import { EAGER_THEME_COMPONENTS } from '../themes/eager-themes-components';
56
import { AdminSidebarComponent } from './admin/admin-sidebar/admin-sidebar.component';
67
import { AdminSidebarSectionComponent } from './admin/admin-sidebar/admin-sidebar-section/admin-sidebar-section.component';
78
import { ExpandableAdminSidebarSectionComponent } from './admin/admin-sidebar/expandable-admin-sidebar-section/expandable-admin-sidebar-section.component';
@@ -38,6 +39,7 @@ const PROVIDERS = [
3839
];
3940

4041
const DECLARATIONS = [
42+
...EAGER_THEME_COMPONENTS,
4143
RootComponent,
4244
ThemedRootComponent,
4345
HeaderComponent,

src/app/shared/listable.module.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ import { FormsModule } from '@angular/forms';
44
import { RouterModule } from '@angular/router';
55
import { TranslateModule } from '@ngx-translate/core';
66

7+
import { THEME_LISTABLE_COMPONENTS } from '../../themes/themes-listable-components';
78
import { CollectionAdminSearchResultGridElementComponent } from '../admin/admin-search-page/admin-search-results/admin-search-result-grid-element/collection-search-result/collection-admin-search-result-grid-element.component';
89
import { CommunityAdminSearchResultGridElementComponent } from '../admin/admin-search-page/admin-search-results/admin-search-result-grid-element/community-search-result/community-admin-search-result-grid-element.component';
910
import { ItemAdminSearchResultGridElementComponent } from '../admin/admin-search-page/admin-search-results/admin-search-result-grid-element/item-search-result/item-admin-search-result-grid-element.component';
@@ -124,6 +125,7 @@ import { TruncatableComponent } from './truncatable/truncatable.component';
124125
import { TruncatablePartComponent } from './truncatable/truncatable-part/truncatable-part.component';
125126

126127
const ENTRY_COMPONENTS = [
128+
...THEME_LISTABLE_COMPONENTS,
127129
BitstreamListItemComponent,
128130
BrowseEntryListElementComponent,
129131
BundleListElementComponent,
Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,32 @@
1+
/* eslint-disable dspace-angular-ts/themed-component-usages */
2+
import { FooterComponent } from './app/footer/footer.component';
3+
import { HeaderComponent } from './app/header/header.component';
4+
import { HeaderNavbarWrapperComponent } from './app/header-nav-wrapper/header-navbar-wrapper.component';
5+
import { HomeNewsComponent } from './app/home-page/home-news/home-news.component';
6+
import { NavbarComponent } from './app/navbar/navbar.component';
7+
import { SearchNavbarComponent } from './app/search-navbar/search-navbar.component';
8+
import { CreateCollectionParentSelectorComponent } from './app/shared/dso-selector/modal-wrappers/create-collection-parent-selector/create-collection-parent-selector.component';
9+
import { CreateCommunityParentSelectorComponent } from './app/shared/dso-selector/modal-wrappers/create-community-parent-selector/create-community-parent-selector.component';
10+
import { CreateItemParentSelectorComponent } from './app/shared/dso-selector/modal-wrappers/create-item-parent-selector/create-item-parent-selector.component';
11+
import { EditCollectionSelectorComponent } from './app/shared/dso-selector/modal-wrappers/edit-collection-selector/edit-collection-selector.component';
12+
import { EditCommunitySelectorComponent } from './app/shared/dso-selector/modal-wrappers/edit-community-selector/edit-community-selector.component';
13+
import { EditItemSelectorComponent } from './app/shared/dso-selector/modal-wrappers/edit-item-selector/edit-item-selector.component';
14+
import { LangSwitchComponent } from './app/shared/lang-switch/lang-switch.component';
15+
import { LogInComponent } from './app/shared/log-in/log-in.component';
16+
17+
export const COMPONENTS = [
18+
HomeNewsComponent,
19+
HeaderComponent,
20+
HeaderNavbarWrapperComponent,
21+
NavbarComponent,
22+
SearchNavbarComponent,
23+
FooterComponent,
24+
CreateCollectionParentSelectorComponent,
25+
CreateCommunityParentSelectorComponent,
26+
CreateItemParentSelectorComponent,
27+
EditCollectionSelectorComponent,
28+
EditCommunitySelectorComponent,
29+
EditItemSelectorComponent,
30+
LogInComponent,
31+
LangSwitchComponent,
32+
];

src/themes/custom/eager-theme.module.ts

Lines changed: 0 additions & 97 deletions
This file was deleted.
Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,29 @@
1+
import { JournalComponent } from './app/entity-groups/journal-entities/item-pages/journal/journal.component';
2+
import { JournalIssueComponent } from './app/entity-groups/journal-entities/item-pages/journal-issue/journal-issue.component';
3+
import { JournalVolumeComponent } from './app/entity-groups/journal-entities/item-pages/journal-volume/journal-volume.component';
4+
import { PersonComponent } from './app/entity-groups/research-entities/item-pages/person/person.component';
5+
import { PublicationComponent } from './app/item-page/simple/item-types/publication/publication.component';
6+
import { UntypedItemComponent } from './app/item-page/simple/item-types/untyped-item/untyped-item.component';
7+
import { BrowseEntryListElementComponent } from './app/shared/object-list/browse-entry-list-element/browse-entry-list-element.component';
8+
import { CollectionListElementComponent } from './app/shared/object-list/collection-list-element/collection-list-element.component';
9+
import { CommunityListElementComponent } from './app/shared/object-list/community-list-element/community-list-element.component';
10+
import { ItemSearchResultListElementComponent } from './app/shared/object-list/search-result-list-element/item-search-result/item-types/item/item-search-result-list-element.component';
11+
import { PublicationSidebarSearchListElementComponent } from './app/shared/object-list/sidebar-search-list-element/item-types/publication/publication-sidebar-search-list-element.component';
12+
13+
/**
14+
* Add components that use the @listableObjectComponent decorator here.
15+
* This will ensure that the decorators get picked up when the app loads
16+
*/
17+
export const LISTABLE_COMPONENTS = [
18+
JournalComponent,
19+
JournalIssueComponent,
20+
JournalVolumeComponent,
21+
PersonComponent,
22+
PublicationComponent,
23+
UntypedItemComponent,
24+
CommunityListElementComponent,
25+
CollectionListElementComponent,
26+
PublicationSidebarSearchListElementComponent,
27+
ItemSearchResultListElementComponent,
28+
BrowseEntryListElementComponent,
29+
];

0 commit comments

Comments
 (0)